Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:49606 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753007AbeCMQrJ (ORCPT ); Tue, 13 Mar 2018 12:47:09 -0400 From: Kalle Valo To: "Luis R. Rodriguez" Cc: Andres Rodriguez , "linux-kernel\@vger.kernel.org" , Greg Kroah-Hartman , linux-wireless , Arend Van Spriel Subject: Re: [PATCH] firmware: add a function to load optional firmware v2 References: <20180309221243.15489-2-andresx7@gmail.com> <20180309230925.3573-1-andresx7@gmail.com> <87a7vcazf1.fsf@kamboji.qca.qualcomm.com> <20180313164026.GG4449@wotan.suse.de> Date: Tue, 13 Mar 2018 18:46:58 +0200 In-Reply-To: <20180313164026.GG4449@wotan.suse.de> (Luis R. Rodriguez's message of "Tue, 13 Mar 2018 16:40:26 +0000") Message-ID: <87fu53apod.fsf@kamboji.qca.qualcomm.com> (sfid-20180313_174727_797779_6CB73065) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org List-ID: "Luis R. Rodriguez" writes: > On Tue, Mar 13, 2018 at 03:16:34PM +0200, Kalle Valo wrote: >> "Luis R. Rodriguez" writes: >> >> >> +/** >> >> + * request_firmware_optional: - request for an optional fw module >> >> + * @firmware_p: pointer to firmware image >> >> + * @name: name of firmware file >> >> + * @device: device for which firmware is being loaded >> >> + * >> >> + * This function is similar in behaviour to request_firmware(), except >> >> + * it doesn't produce warning messages when the file is not found. >> >> + **/ >> >> +int >> >> +request_firmware_optional(const struct firmware **firmware_p, const char *name, >> >> + struct device *device) >> >> +{ >> >> + int ret; >> >> + >> >> + /* Need to pin this module until return */ >> >> + __module_get(THIS_MODULE); >> >> + ret = _request_firmware(firmware_p, name, device, NULL, 0, >> >> + FW_OPT_UEVENT | FW_OPT_NO_WARN ); >> >> + module_put(THIS_MODULE); >> >> + return ret; >> >> +} >> >> +EXPORT_SYMBOL(request_firmware_optional); >> > >> > New exported symbols for the firmware API should be EXPORT_SYMBOL_GPL(). >> >> To me the word optional feels weird to me. For example, in ath10k I >> suspect we would be only calling request_firmware_optional() with all >> firmware and not request_firmware() at all. >> >> How about request_firmware_nowarn()? That would even match the >> documentation above. > > _nowarn() works with me. Do you at least want the return value to give > an error value if no file was found? This way the driver can decide > when to issue an error if it wants to. Yes, it would be very good to return the error value to ath10k. That way we can give a proper error message to the user if we can't find a suitable firmware image. -- Kalle Valo