Return-path: Received: from mail-wm0-f66.google.com ([74.125.82.66]:53358 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752746AbeCMUVX (ORCPT ); Tue, 13 Mar 2018 16:21:23 -0400 Received: by mail-wm0-f66.google.com with SMTP id e194so293961wmd.3 for ; Tue, 13 Mar 2018 13:21:22 -0700 (PDT) Subject: Re: [2/3] mwifiex: support sysfs initiated device coredump To: Marcel Holtmann References: <1519210220-22437-3-git-send-email-arend.vanspriel@broadcom.com> <20180312094115.2E1C1606DB@smtp.codeaurora.org> <5AA67616.2000602@broadcom.com> <87efkoazow.fsf@kamboji.qca.qualcomm.com> <5AA829A1.1090209@broadcom.com> <24B25258-E680-490C-B7FF-D34CEBBA8566@holtmann.org> Cc: Kalle Valo , linux-wireless , Linux Bluetooth mailing list , LKML , Greg Kroah-Hartman From: Arend van Spriel Message-ID: <5AA832B7.2010007@broadcom.com> (sfid-20180313_212135_545517_9E86720E) Date: Tue, 13 Mar 2018 21:21:11 +0100 MIME-Version: 1.0 In-Reply-To: <24B25258-E680-490C-B7FF-D34CEBBA8566@holtmann.org> Content-Type: text/plain; charset=windows-1252; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 3/13/2018 9:19 PM, Marcel Holtmann wrote: > Hi Arend, > >>>>>> Since commit 3c47d19ff4dc ("drivers: base: add coredump driver ops") >>>>>> it is possible to initiate a device coredump from user-space. This >>>>>> patch adds support for it adding the .coredump() driver callback. >>>>>> As there is no longer a need to initiate it through debugfs remove >>>>>> that code. >>>>>> >>>>>> Signed-off-by: Arend van Spriel >>>>> >>>>> Based on the discussion I assume this is ok to take to w-d-next. If that's not >>>>> the case, please let me know ASAP. >>>> >>>> It is up to the mwifiex maintainers to decide, I guess. The ABI >>>> documentation need to be revised and change the callback to void >>>> return type. I am not sure what the best approach is. 1) apply this >>>> and fix return type later, or 2) fix return type and resubmit this. >>>> What is your opinion? >>> >>> I guess the callback change will go through Greg's tree? Then I suspect >>> it's easier that you submit the callback change to Greg first and wait >>> for it to trickle down to wireless-drivers-next (after the next merge >>> window) and then I can apply the driver patches. Otherwise there might >>> be a conflict between my and Greg's tree. >> >> That was my assessment, but unfortunately Marcel already applied the btmrvl patch before I could reply. So how do I move from here? Option 1) revert brmrvl and fix callback return type, or 2) apply mwifiex patch and fix callback return type later for both drivers. > > I can take the patch back out of bluetooth-next if needed. It is your call. Thanks, Marcel Let's go for that. Please revert/remove the patch. Regards, Arend