Return-path: Received: from mail-wm0-f44.google.com ([74.125.82.44]:53134 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932314AbeCKXKs (ORCPT ); Sun, 11 Mar 2018 19:10:48 -0400 Received: by mail-wm0-f44.google.com with SMTP id t3so13046021wmc.2 for ; Sun, 11 Mar 2018 16:10:47 -0700 (PDT) Subject: Re: [PATCH] firmware: add a function to load optional firmware v2 To: Andres Rodriguez , "Luis R. Rodriguez" References: <20180309221243.15489-2-andresx7@gmail.com> <20180309230925.3573-1-andresx7@gmail.com> Cc: "linux-kernel@vger.kernel.org" , Greg Kroah-Hartman , linux-wireless , Kalle Valo , Ilia Mirkin From: Arend van Spriel Message-ID: <5AA5B777.5020106@broadcom.com> (sfid-20180312_001103_474519_09E3D8F0) Date: Mon, 12 Mar 2018 00:10:47 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 3/11/2018 5:05 PM, Andres Rodriguez wrote: >> Your patch series then should also have the driver callers who you >> want to modify to use this new API. Collect from the 802.11 folks the >> other drivers which I think they wanted changed as well. > > Arend, Kalle, would love to hear your feedback. I am not sure if it was ath10k, but Kalle will surely know. The other driver firing a whole batch of firmware requests is iwlwifi. These basically try to get latest firmware version and if not there try an older one. The brcmfmac driver I maintain is slightly different. It downloads two distinct pieces of firmware of which one is optional for certain configurations. Currently, my driver does two asynchronous requests for it, but I consider changing it and only make the first request asynchronous and the second request synchronous. You can look at the current code in drivers/net/wireless/broadcom/brcmfmac/firmware.c. However, I did quite some restructuring last week. Anyway, I probably will end up using the "optional" api where appropriate. Regards, Arend