Return-path: Received: from smtps.newmedia-net.de ([185.84.6.167]:53619 "EHLO webmail.newmedia-net.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1425613AbeCBJWc (ORCPT ); Fri, 2 Mar 2018 04:22:32 -0500 Subject: Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets To: Pavel Machek Cc: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , "open list:LED SUBSYSTEM" , "linux-wireless@vger.kernel.org" , Kalle Valo , ath10k@lists.infradead.org, Sebastian Gottschall References: <20180226084406.2093-1-s.gottschall@dd-wrt.com> <82d8ac0c-b391-6099-4c7f-991cc35445aa@dd-wrt.com> <20180302090312.GA30267@amd> From: Sebastian Gottschall Message-ID: (sfid-20180302_102330_855697_C6862217) Date: Fri, 2 Mar 2018 10:22:14 +0100 MIME-Version: 1.0 In-Reply-To: <20180302090312.GA30267@amd> Content-Type: text/plain; charset=windows-1252; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: >> leds-gpio is crap and limited. you can just register one platform data at >> kernel runtime since its identified by its object name "led-gpio" but the >> kernel forbidds to register 2 platform datas with the same name >> consider the ar71xx devices with qca988x wifi chipsets. they all have >> already a led platform data registered >> at boottime. a second can't be registered anymore so gpio_led is useless at >> all for most developers on such platforms. its mainly used for early kernel >> platform data initialisation for system leds. > If leds-gpio has limitations, please fix those, rather then > introducing duplicated code. there is no duplicated code introduced and there is no solution for it. consider that all wifi drivers with softled support are going that way with registering a own led driver. see ath9k for instance. gpio-led cannot be used for it and there is no way to support multiple platform datas with the same name. its a kernel limitation Sebastian > > NAK. > Pavel -- Mit freundlichen Gr?ssen / Regards Sebastian Gottschall / CTO NewMedia-NET GmbH - DD-WRT Firmensitz: Stubenwaldallee 21a, 64625 Bensheim Registergericht: Amtsgericht Darmstadt, HRB 25473 Gesch?ftsf?hrer: Peter Steinh?user, Christian Scheele http://www.dd-wrt.com email: s.gottschall@dd-wrt.com Tel.: +496251-582650 / Fax: +496251-5826565