Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:33404 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756683AbeDXJsH (ORCPT ); Tue, 24 Apr 2018 05:48:07 -0400 From: Kalle Valo To: merez@codeaurora.org Cc: Alexei Avshalom Lazar , linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com, linux-wireless-owner@vger.kernel.org Subject: Re: [02/10] wil6210: set/get EDMG channel through debugfs References: <1523520526-24997-3-git-send-email-merez@codeaurora.org> <20180419161506.868FA60A06@smtp.codeaurora.org> Date: Tue, 24 Apr 2018 12:47:55 +0300 In-Reply-To: (merez@codeaurora.org's message of "Sun, 22 Apr 2018 15:40:34 +0300") Message-ID: <878t9dorzo.fsf@codeaurora.org> (sfid-20180424_114818_557914_D60F2E82) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org List-ID: merez@codeaurora.org writes: > On 2018-04-19 19:15, Kalle Valo wrote: >> Maya Erez wrote: >> >>> Setting EDMG channel through debugfs for connect and PCP start >>> commands. >> Why? And what is an EDMG channel? >> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#commit_log_does_not_answer_why >> I get bad vibes that this debugfs file is just a workaround for not >> adding this to nl80211, a proper commit log would not give me such >> vibes in the first place :) > > EDMG (Enhanced Directional Multi-Gigabit) is a new feature, part of > 11ad/11ay specification. In a nutshell it allows channel bonding of > 60Ghz channels. > > The debugfs is used for debug-only to allow forcing a channel, not > intended to replace NL API, which we are working to upstream such. But why cannot you do debugging via nl80211 as well? -- Kalle Valo