Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:39814 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753717AbeDZIQy (ORCPT ); Thu, 26 Apr 2018 04:16:54 -0400 From: Kalle Valo To: Eyal Reizer Cc: linux-wireless@vger.kernel.org, robh@kernel.org, sre@kernel.org, tony@atomide.com, linux-kernel@vger.kernel.org, Eyal Reizer Subject: Re: [PATCH v2] wlcore: sdio: allow pm to handle sdio power References: <1524721631-5983-1-git-send-email-eyalr@ti.com> Date: Thu, 26 Apr 2018 11:16:48 +0300 In-Reply-To: <1524721631-5983-1-git-send-email-eyalr@ti.com> (Eyal Reizer's message of "Thu, 26 Apr 2018 08:47:11 +0300") Message-ID: <87po2m7573.fsf@kamboji.qca.qualcomm.com> (sfid-20180426_101714_603834_68CDB402) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org List-ID: Eyal Reizer writes: > pm_runtime handles sdio power on and power off transitions. > An old workaround for trying to control the power explicitly from the > driver was in fact causing failures on suspend/resume as the mmc layer > already power the module on resume. > > In case of resume pm_runtime_get sync returns a positive device's usage > count causing the driver to try an re-initialize an already initialized > device. This was causing sdio bus failure on resume. > > Remove this manual power on/off sequence as it is in-fact not needed. > > Signed-off-by: Eyal Reizer > Acked-by: Tony Lindgren No changelog. https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#changelog_missing No need to resubmit because of this, I guess you just fixed the title and added Tony's Acked-by? -- Kalle Valo