Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:58810 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755968AbeDXFfI (ORCPT ); Tue, 24 Apr 2018 01:35:08 -0400 From: Kalle Valo To: Adrian Chadd Cc: Arend van Spriel , Sebastian Gottschall , govinds@codeaurora.org, pillair@codeaurora.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Subject: Re: [PATCH v2 4/4] ath10k: Enable sta idle power save References: <1523966821-21903-1-git-send-email-pillair@codeaurora.org> <1523966821-21903-5-git-send-email-pillair@codeaurora.org> <946e582c-2438-872b-eec8-25d9dcb994d9@dd-wrt.com> <7a06a34a5fcb97e07a8d79b4d689e781@codeaurora.org> <87604oodt4.fsf@kamboji.qca.qualcomm.com> <8736zrjgq6.fsf@kamboji.qca.qualcomm.com> <5AD9A1DF.6060007@broadcom.com> <87wowxdirv.fsf@kamboji.qca.qualcomm.com> Date: Tue, 24 Apr 2018 08:35:03 +0300 In-Reply-To: (Adrian Chadd's message of "Mon, 23 Apr 2018 09:41:06 -0700") Message-ID: <87bme9cgl4.fsf@kamboji.qca.qualcomm.com> (sfid-20180424_073533_466643_196631EF) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org List-ID: Adrian Chadd writes: > On 23 April 2018 at 08:50, Kalle Valo wrote: > >> >> Adrian was also commenting something similar about adding a debugfs >> interface but I don't really see the point right now while we are adding >> initial wcn3990 support. If someone wants to run measurements with and >> without this parameter it's very easy to edit it out from the sources. >> Later on we can consider making it dynamic if there's really the need >> for that, but I'm very skeptic that anyone would even need that. > > Hi! > > We have at ${WORK}, because we've found various devices (atheros and > qualcomm and QCA and otherwise) have this nasty habit of trying to > guess when a good time to clock-gate down is, but we're busy doing low > latency audio/video. > > 10, 20ms may not be a lot of latency for bulk data but that's a half > to one of a video frame in my world. :-) Sure, I get that. But we should discuss making a setting like this dynamic once we have a test case and numbers showing that it's needed, otherwise it's just unnecessary cruft. -- Kalle Valo