Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:53210 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751107AbeDPON4 (ORCPT ); Mon, 16 Apr 2018 10:13:56 -0400 From: Kalle Valo To: Daniel Mack Cc: linux-wireless@vger.kernel.org, wcn36xx@lists.infradead.org, loic.poulain@linaro.org, rfried@codeaurora.org, bjorn.andersson@linaro.org Subject: Re: [PATCH 5/5] wcn36xx: pass information elements in scan requests References: <20180416131634.25432-1-daniel@zonque.org> <20180416131634.25432-6-daniel@zonque.org> <87lgdnp7sy.fsf@kamboji.qca.qualcomm.com> <0595a559-8220-bc22-0c33-4580119c774d@zonque.org> Date: Mon, 16 Apr 2018 17:13:51 +0300 In-Reply-To: <0595a559-8220-bc22-0c33-4580119c774d@zonque.org> (Daniel Mack's message of "Mon, 16 Apr 2018 16:06:49 +0200") Message-ID: <87h8obp7c0.fsf@kamboji.qca.qualcomm.com> (sfid-20180416_161400_384853_0A8253FA) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org List-ID: Daniel Mack writes: > On Monday, April 16, 2018 04:03 PM, Kalle Valo wrote: >> Daniel Mack writes: >> >>> When the ieee8022 core passes IE elements in the scan request, append >> >> You mean mac80211? >> >> And yeah, the ieee80211_ prefix is confusing. Many many years I >> started to change that to mac80211_ but gave up :( > > Ah, yeah. I was just referring to the wifi core driver stack. We call the components mac80211 and cfg80211, please don't invent new names for them. >>> them to the firmware message. The driver currently tells the core that >>> it is capable of attaching up to WCN36XX_MAX_SCAN_IE_LEN octets, but >>> doesn't actually pass them to the the hardware. >>> >>> Some defines were moved around to avoid cyclic include dependencies. >> >> Does this fix anything or change functionality somehow? You should >> document that also in the commit log. > > I don't have a test case for this, no. But as the change was pretty much > straight forward, I sent it anyway. Ok, but you should still explain that in the commit log. In other words, you should always answer the question "Why?" in the commit log. > I can resend with some more information on this if you like. No need to resend because of this, I can edit the commit log. -- Kalle Valo