Return-path: Received: from nbd.name ([46.4.11.11]:33306 "EHLO nbd.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751179AbeDEOF7 (ORCPT ); Thu, 5 Apr 2018 10:05:59 -0400 Subject: Re: [PATCH 00/12] Ethernet: Add and use ether__addr globals To: Joe Perches , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org, bridge@lists.linux-foundation.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org Cc: linux-kernel@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com References:

<1522936292.11185.15.camel@perches.com> From: Felix Fietkau Message-ID: <999e4ee7-2e4e-6bf9-ac76-209e259c83e4@nbd.name> (sfid-20180405_160616_578496_A2E77C56) Date: Thu, 5 Apr 2018 16:05:51 +0200 MIME-Version: 1.0 In-Reply-To: <1522936292.11185.15.camel@perches.com> Content-Type: text/plain; charset=utf-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 2018-04-05 15:51, Joe Perches wrote: >> You have to factor in >> not just the .text size, but the fact that referencing an exported >> symbol needs a .reloc entry as well, which also eats up some space (at >> least when the code is being built as module). > > Thanks, the modules I built got smaller. Please post some numbers to show this. By the way, on other architectures the numbers will probably be different, especially on ARM/MIPS. >> In my opinion, your series probably causes more bloat in common >> configurations instead of reducing it. >> >> You're also touching several places that could easily use >> eth_broadcast_addr and eth_zero_addr. I think making those changes would >> be more productive than what you did in this series. > > Doubtful. AFAIK: possible unaligned addresses. Those two are just memset calls, alignment does not matter. - Felix