Return-path: Received: from mail-wm0-f68.google.com ([74.125.82.68]:33078 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752565AbeDETAi (ORCPT ); Thu, 5 Apr 2018 15:00:38 -0400 Received: by mail-wm0-f68.google.com with SMTP id o23so4676244wmf.0 for ; Thu, 05 Apr 2018 12:00:38 -0700 (PDT) Subject: Re: [PATCH 07/12] brcmfmac: Convert ALLFFMAC to ether_broadcast_addr To: Joe Perches , linux-kernel@vger.kernel.org References: Cc: Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , Kalle Valo , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, netdev@vger.kernel.org From: Arend van Spriel Message-ID: <5AC67254.1000007@broadcom.com> (sfid-20180405_210114_247612_72B40FBF) Date: Thu, 5 Apr 2018 21:00:36 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 3/31/2018 9:05 AM, Joe Perches wrote: > Remove the local ALLFFMAC extern array and use the new global instead. I stumbled upon this one couple of weeks ago. I moved the definition to flowring.c although I considered for a moment to pick up the task you took here valiantly. > Miscellanea: > > o Convert char *mac to const char *mac as it can't be modified The real reason is off course that your new global is const and thus mac variable need to be const as well to avoid compiler warning. I have to agree with Kalle regarding the upstream logistics, but for what it is worth... Acked-by: Arend van Spriel > Signed-off-by: Joe Perches > --- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c | 2 -- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.h | 2 -- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/flowring.c | 8 ++++---- > 3 files changed, 4 insertions(+), 8 deletions(-)