Subject: Re: [PATCH 5/5] wcn36xx: pass information elements in scan requests
To: Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, wcn36xx@lists.infradead.org,
        loic.poulain@linaro.org, rfried@codeaurora.org,
        bjorn.andersson@linaro.org
References: <20180416131634.25432-1-daniel@zonque.org>
 <20180416131634.25432-6-daniel@zonque.org>
 <87lgdnp7sy.fsf@kamboji.qca.qualcomm.com>
From: Daniel Mack <daniel@zonque.org>
Message-ID: <0595a559-8220-bc22-0c33-4580119c774d@zonque.org> (sfid-20180416_160655_062574_18C32BFA)
Date: Mon, 16 Apr 2018 16:06:49 +0200
MIME-Version: 1.0
In-Reply-To: <87lgdnp7sy.fsf@kamboji.qca.qualcomm.com>
Content-Type: text/plain; charset=utf-8
Sender: linux-wireless-owner@vger.kernel.org

On Monday, April 16, 2018 04:03 PM, Kalle Valo wrote:
> Daniel Mack <daniel@zonque.org> writes:
> 
>> When the ieee8022 core passes IE elements in the scan request, append
> 
> You mean mac80211?
> 
> And yeah, the ieee80211_ prefix is confusing. Many many years I
> started to change that to mac80211_ but gave up :(

Ah, yeah. I was just referring to the wifi core driver stack.

>> them to the firmware message. The driver currently tells the core that
>> it is capable of attaching up to WCN36XX_MAX_SCAN_IE_LEN octets, but
>> doesn't actually pass them to the the hardware.
>>
>> Some defines were moved around to avoid cyclic include dependencies.
> 
> Does this fix anything or change functionality somehow? You should
> document that also in the commit log.

I don't have a test case for this, no. But as the change was pretty much
straight forward, I sent it anyway.

I can resend with some more information on this if you like.


Thanks,
Daniel