Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:51270 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750882AbeDYI02 (ORCPT ); Wed, 25 Apr 2018 04:26:28 -0400 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Subject: Re: qtnfmac: pearl: pcie: fix memory leak in qtnf_fw_work_handler From: Kalle Valo In-Reply-To: <20180405154949.GA32223@embeddedor.com> References: <20180405154949.GA32223@embeddedor.com> To: "Gustavo A. R. Silva" Cc: Igor Mitsyanko , Avinash Patil , Sergey Matyukevich , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Message-Id: <20180425082628.498886070B@smtp.codeaurora.org> (sfid-20180425_102708_199885_03EDABBD) Date: Wed, 25 Apr 2018 08:26:28 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org List-ID: "Gustavo A. R. Silva" wrote: > In case memory resources for fw were succesfully allocated, release > them before jumping to fw_load_fail. > > Addresses-Coverity-ID: 1466092 ("Resource leak") > Fixes: c3b2f7ca4186 ("qtnfmac: implement asynchronous firmware loading") > Signed-off-by: Gustavo A. R. Silva > Reviewed-by: Sergey Matyukevich Patch applied to wireless-drivers-next.git, thanks. 376377004464 qtnfmac: pearl: pcie: fix memory leak in qtnf_fw_work_handler -- https://patchwork.kernel.org/patch/10324855/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches