Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:39468 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750852AbeEKKSf (ORCPT ); Fri, 11 May 2018 06:18:35 -0400 From: Kalle Valo To: Larry Finger Cc: =?utf-8?Q?Rafa=C5=82_Mi=C5=82ecki?= , Michael =?utf-8?Q?B=C3=BCsch?= , Matt Redfearn , linux-wireless@vger.kernel.org, Hauke Mehrtens , LKML , =?utf-8?Q?Rafa?= =?utf-8?Q?=C5=82_Mi=C5=82ecki?= Subject: Re: [PATCH 4.17 2/2] ssb: make SSB_PCICORE_HOSTMODE depend on SSB = y References: <20180510111401.1161-1-zajec5@gmail.com> <20180510111401.1161-2-zajec5@gmail.com> Date: Fri, 11 May 2018 13:18:30 +0300 In-Reply-To: (Larry Finger's message of "Thu, 10 May 2018 11:07:09 -0500") Message-ID: <8736yycx6x.fsf@codeaurora.org> (sfid-20180511_121902_760584_62B3D542) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: Larry Finger writes: > On 05/10/2018 06:14 AM, Rafa=C5=82 Mi=C5=82ecki wrote: >> From: Rafa=C5=82 Mi=C5=82ecki >> >> SSB_PCICORE_HOSTMODE protects MIPS specific code that calls not exported >> symbols pcibios_enable_device and register_pci_controller. This code is >> supposed to be compiled only with ssb builtin. >> >> This fixes: >> ERROR: "pcibios_enable_device" [drivers/ssb/ssb.ko] undefined! >> ERROR: "register_pci_controller" [drivers/ssb/ssb.ko] undefined! >> make[1]: *** [scripts/Makefile.modpost:92: __modpost] Error 1 >> >> Signed-off-by: Rafa=C5=82 Mi=C5=82ecki > > This patch needs a "Reported-by: Matt Redfearn ". > > Applying both patches leads to a correct configuration for PCI. I > cannot test on my present hardware, but the patches seem to be > correct. > > Reviewed-by: Larry Finger > > @Kalle: Please drop my patch from yesterday. This solution is much better. Dropped, thanks for letting me know. --=20 Kalle Valo