Return-path: Received: from mail.kernel.org ([198.145.29.99]:43846 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751326AbeEBSEH (ORCPT ); Wed, 2 May 2018 14:04:07 -0400 Date: Wed, 2 May 2018 11:03:56 -0700 From: Greg KH To: Andy Shevchenko Cc: Amit Pundir , lkml , linux-wireless@vger.kernel.org, Samuel Ortiz , Christophe Ricard , John Stultz Subject: Re: [PATCH] NFC: fdp: Remove __func__ parameter from dev_dbg() call Message-ID: <20180502180356.GA4660@kroah.com> (sfid-20180502_200637_764557_6FCB65A4) References: <1525283379-7141-1-git-send-email-amit.pundir@linaro.org> <1525283968.21176.633.camel@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1525283968.21176.633.camel@linux.intel.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, May 02, 2018 at 08:59:28PM +0300, Andy Shevchenko wrote: > On Wed, 2018-05-02 at 23:19 +0530, Amit Pundir wrote: > > > - dev_dbg(dev, "%s\n", __func__); > > + dev_dbg(dev, "\n"); > > If one enables function tracer this will be redundant completely. Yes those kinds of "trace" debug log messages should be just deleted.