Subject: Re: [PATCH] cfg80211: Fix support for flushing old scan results
To: Denis Kenzior <denkenz@gmail.com>,
        Johannes Berg <johannes@sipsolutions.net>,
        Tim Kourt <tim.a.kourt@linux.intel.com>
References: <20180511164835.40161-1-tim.a.kourt@linux.intel.com>
 <1526631206.3805.1.camel@sipsolutions.net>
 <d12d4d4d-25d6-3cd0-1399-27de09c7f8c5@gmail.com>
Cc: linux-wireless@vger.kernel.org
From: Arend van Spriel <arend.vanspriel@broadcom.com>
Message-ID: <5AFF2169.4010003@broadcom.com> (sfid-20180518_205441_305117_13F0315B)
Date: Fri, 18 May 2018 20:54:33 +0200
MIME-Version: 1.0
In-Reply-To: <d12d4d4d-25d6-3cd0-1399-27de09c7f8c5@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Sender: linux-wireless-owner@vger.kernel.org

On 5/18/2018 6:47 PM, Denis Kenzior wrote:
> Hi Johannes,
>
> On 05/18/2018 03:13 AM, Johannes Berg wrote:
>> On Fri, 2018-05-11 at 09:48 -0700, Tim Kourt wrote:
>>> __cfg80211_bss_expire function was incorrectly used to flush the BSS
>>> entries from the previous scan results, causing NL80211_SCAN_FLAG_FLUSH
>>> flag to have no effect.
>>
>> Hmm. I guess I'm not convinced - what's the bug?
>>
>> We flush anything that's older than our start, so that should work just
>> fine?
>>
>
> Just FYI, there's definitely something funny with the scanning code:
>
> denkenz@iwd-test ~ $ sudo iw dev wlp2s0 scan flush
> BSS 10:c3:7b:54:74:d4(on wlp2s0)
>      last seen: 274.815s [boottime]
>      freq: 5765
>      beacon interval: 100 TUs
>      signal: -35.00 dBm
>      last seen: 349 ms ago
>      Information elements from Probe Response frame:
>      SSID: \x00\x00\x00\x00\x00\x00\x00\x00\x00
>
>
> Then if I try:
> denkenz@iwd-test ~ $ sudo iw dev wlp2s0 scan flush ssid myssid
> BSS 10:c3:7b:54:74:d4(on wlp2s0)
>      last seen: 319.667s [boottime]
>      freq: 5765
>      beacon interval: 100 TUs
>      signal: -42.00 dBm
>      last seen: 350 ms ago
>      Information elements from Probe Response frame:
>      SSID: \x00\x00\x00\x00\x00\x00\x00\x00\x00
> ....
> BSS 10:c3:7b:54:74:d4(on wlp2s0)
>      last seen: 319.662s [boottime]
>      freq: 5765
>      beacon interval: 100 TUs
>      signal: -37.00 dBm
>      last seen: 355 ms ago
>      Information elements from Probe Response frame:
>      SSID: myssid
>
> Shouldn't the second scan give a single result from that one BSS?

Looking at the 'last seen' values it does look ok. Both results have the 
same BSSID, but the first one shows the broadcast ssid (or so it seems). 
Neither iw nor nl80211 on the kernel side add the broadcast ssid. So 
question is what device are you using and does it use mac80211 software 
scanning or hardware scanning. I did not dive into mac80211 to see if 
the broadcast ssid is added there.

Regards,
Arend