Return-path: Received: from mail-wm0-f50.google.com ([74.125.82.50]:35889 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750852AbeEKKZg (ORCPT ); Fri, 11 May 2018 06:25:36 -0400 MIME-Version: 1.0 In-Reply-To: <87bmdmcxf6.fsf@codeaurora.org> References: <20180511091715.1989-1-zajec5@gmail.com> <87bmdmcxf6.fsf@codeaurora.org> From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Date: Fri, 11 May 2018 12:25:33 +0200 Message-ID: (sfid-20180511_122547_268065_23985671) Subject: Re: [PATCH V2 1/2] Revert "ssb: Prevent build of PCI host features in module" To: Kalle Valo Cc: =?UTF-8?Q?Michael_B=C3=BCsch?= , Larry Finger , Matt Redfearn , "linux-wireless@vger.kernel.org" , Hauke Mehrtens , LKML , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Content-Type: text/plain; charset="UTF-8" Sender: linux-wireless-owner@vger.kernel.org List-ID: On 11 May 2018 at 12:13, Kalle Valo wrote: > Rafa=C5=82 Mi=C5=82ecki writes: > >> On 11 May 2018 at 11:17, Rafa=C5=82 Mi=C5=82ecki wrot= e: >>> From: Rafa=C5=82 Mi=C5=82ecki >>> >>> This reverts commit 882164a4a928bcaa53280940436ca476e6b1db8e. >>> >>> Above commit added "SSB =3D y" dependency to the wrong symbol >>> SSB_DRIVER_PCICORE_POSSIBLE and prevented SSB_DRIVER_PCICORE from being >>> selected when needed. PCI core driver for core running in clienthost >>> mode is important for bus initialization. It's perfectly valid scenario >>> to have ssb built as module and use it with buses on PCI cards. >>> >>> This fixes regression that affected all *module* users with PCI cards. >>> >>> Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=3D1572349 >>> Signed-off-by: Rafa=C5=82 Mi=C5=82ecki >> >> As these patches fix regression/build error, I believe both should get >> into 4.17. > > How much confidence do we have that we don't need to end up reverting > patch 2 as well? I rather be pushing patch 2 to 4.18 so that there's > more time for testing and waiting for feedback. Solution from 2/2 seems pretty obvious. 1) Enabling SSB_PCICORE_HOSTMODE compiles code that requires non-exported symbols. Requiring "SSB =3D y" seems pretty obvious. 2) As pointed in another e-mail bcma has pretty identical solution that seems to be working well, see commit 79ca239a68f8f ("bcma: Prevent build of PCI host features in module"). That's just my opinion though, I shared since you asked. If you prefer to queue that for 4.18, I'm OK. After all: 1) This problem affects MIPS arch only 2) It can be fixed by not selecting BCMA_DRIVER_PCI_HOSTMODE for SSB =3D m --=20 Rafa=C5=82