Return-path: Received: from mail-qt0-f193.google.com ([209.85.216.193]:35000 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751452AbeERKGc (ORCPT ); Fri, 18 May 2018 06:06:32 -0400 Received: by mail-qt0-f193.google.com with SMTP id f5-v6so9536257qth.2 for ; Fri, 18 May 2018 03:06:32 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <58c8d2d16995e80f5527370e224045e2@codeaurora.org> References: <20180517113250.16517-1-ramon.fried@linaro.org> <58c8d2d16995e80f5527370e224045e2@codeaurora.org> From: Ramon Fried Date: Fri, 18 May 2018 13:06:31 +0300 Message-ID: (sfid-20180518_120652_962618_328DCFF4) Subject: Re: [PATCH] wcn36xx: Add support for Factory Test Mode (FTM) To: Jeff Johnson Cc: kvalo@codeaurora.org, linux-kernel@vger.kernel.org, wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Eyal Ilsar , linux-wireless-owner@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-wireless-owner@vger.kernel.org List-ID: On 17 May 2018 at 21:37, Jeff Johnson wrote: > On 2018-05-17 04:32, Ramon Fried wrote: >> >> From: Eyal Ilsar > > ... >> >> +int wcn36xx_smd_process_ptt_msg(struct wcn36xx *wcn, >> + struct ieee80211_vif *vif, void *ptt_msg, >> size_t len, >> + void **ptt_rsp_msg) >> +{ >> + struct wcn36xx_hal_process_ptt_msg_req_msg *p_msg_body; >> + int ret = 0; >> + >> + mutex_lock(&wcn->hal_mutex); >> + p_msg_body = kmalloc( >> + sizeof(struct wcn36xx_hal_process_ptt_msg_req_msg) + len, >> + GFP_ATOMIC); > > > NULL check required? > >> + INIT_HAL_PTT_MSG(p_msg_body, len); >> + Thanks Jeff. will fix it and send again :)