Return-path: <linux-wireless-owner@vger.kernel.org>
Received: from mail-wr0-f196.google.com ([209.85.128.196]:34591 "EHLO
        mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754057AbeFLMVX (ORCPT
        <rfc822;linux-wireless@vger.kernel.org>);
        Tue, 12 Jun 2018 08:21:23 -0400
Received: by mail-wr0-f196.google.com with SMTP id a12-v6so23873097wro.1
        for <linux-wireless@vger.kernel.org>; Tue, 12 Jun 2018 05:21:23 -0700 (PDT)
Message-ID: <411d1d752811ce2b701d9f3a0d20f05050dc2e09.camel@gmail.com> (sfid-20180612_142127_575426_2F5C18CE)
Subject: Re: [PATCH v2] ath10k: Update the phymode along with bandwidth
 change request
From: Timur =?ISO-8859-1?Q?Krist=F3f?= <timur.kristof@gmail.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Ryan Hsu <ryanhsu@codeaurora.org>, ath10k@lists.infradead.org,
        linux-wireless@vger.kernel.org
Date: Tue, 12 Jun 2018 14:21:20 +0200
In-Reply-To: <87muw0cjwq.fsf@kamboji.qca.qualcomm.com>
References: <1528482759-12604-1-git-send-email-ryanhsu@codeaurora.org>
         <944989ec907b98716f252524cf55e41807965253.camel@gmail.com>
         <87muw0cjwq.fsf@kamboji.qca.qualcomm.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Sender: linux-wireless-owner@vger.kernel.org
List-ID: <linux-wireless.vger.kernel.org>

On Tue, 2018-06-12 at 14:40 +0300, Kalle Valo wrote:
> Timur Kristóf <timur.kristof@gmail.com> writes:
> 
> > On Fri, 2018-06-08 at 11:32 -0700, Ryan Hsu wrote:
> > > In the case of Station connects to AP with narrower bandwidth at
> > > beginning.
> > > And later the AP changes the bandwidth to winder bandwidth, the
> > > AP
> > > will
> > > beacon with wider bandwidth IE, eg VHT20->VHT40->VHT80 or VHT40-
> > > > VHT80.
> > > 
> > > Since the supported BANDWIDTH will be limited by the PHYMODE, so
> > > while
> > > Station receives the bandwidth change request, it will also need
> > > to
> > > reconfigure the PHYMODE setting to firmware instead of just
> > > configuring
> > > the BANDWIDTH info, otherwise it'll trigger a firmware crash with
> > > non-support bandwidth.
> > > 
> > > The issue was observed in WLAN.RM.4.4.1-00051-QCARMSWP-1, QCA6174
> > > with
> > > below scenario.
> 
> [...]
> 
> > I can confirm that this patch works on my machine, and prevents the
> > crash previously caused by changing the bandwidth.
> 
> Great, thanks a lot for working on this. I'll add your Tested-by to
> the
> commit log.

Thanks!

> > Can it be accepted, or is there anything I can help with, to get it
> > accepted?
> 
> Strangely I can't find Timur's version of the patch from patchwork:
> 
> https://patchwork.kernel.org/project/linux-wireless/list/?state=*
> 
> Maybe it got dropped due to some UTF-8 problems? patchwork is known
> to
> be problematic with UTF-8.

Not sure. It doesn't really matter now, Ryan's version is fine too.

> Anyway, I'll queue Ryan's v2 to 4.18. It first goes to the pending
> branch for build testing and from there to ath-current branch.

Awesome, thank you Kalle!

Best regards,
Tim