Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:48388 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752774AbeFDNlz (ORCPT ); Mon, 4 Jun 2018 09:41:55 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Date: Mon, 04 Jun 2018 19:11:54 +0530 From: Govind Singh To: Niklas Cassel Cc: Kalle Valo , Wei Yongjun , kernel-janitors@vger.kernel.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, bjorn.andersson@linaro.org Subject: Re: [PATCH net-next] ath10k: make some functions static In-Reply-To: <20180604120400.GA6240@centauri.lan> References: <1527733994-149212-1-git-send-email-weiyongjun1@huawei.com> <87a7sazw0w.fsf@kamboji.qca.qualcomm.com> <20180604120400.GA6240@centauri.lan> Message-ID: (sfid-20180604_154206_021602_5E33AB3C) Sender: linux-wireless-owner@vger.kernel.org List-ID: On 2018-06-04 17:34, Niklas Cassel wrote: > On Mon, Jun 04, 2018 at 01:27:43PM +0300, Kalle Valo wrote: >> Wei Yongjun writes: >> >> > Fixes the following sparse warnings: >> > >> > drivers/net/wireless/ath/ath10k/snoc.c:823:5: warning: >> > symbol 'ath10k_snoc_get_ce_id_from_irq' was not declared. Should it be static? >> > drivers/net/wireless/ath/ath10k/snoc.c:871:6: warning: >> > symbol 'ath10k_snoc_init_napi' was not declared. Should it be static? >> > >> > Signed-off-by: Wei Yongjun >> >> BTW this goes to my ath.git tree, not to net-next. >> >> I had missed these as I can't enable ATH10K_SNOC on x86 and hence I >> don't test compile snoc.c at all. Bjorn&Govind, is there a way to >> solve >> that? IIRC we had a similar problem with wcn36xx but I don't remember >> anymore how it was fixed. >> I tested compilation in x86 by removing ARCH_QCOM dependency last time. > > Perhaps something like: > > --- a/drivers/net/wireless/ath/ath10k/Kconfig > +++ b/drivers/net/wireless/ath/ath10k/Kconfig > @@ -42,7 +42,8 @@ config ATH10K_USB > > config ATH10K_SNOC > tristate "Qualcomm ath10k SNOC support (EXPERIMENTAL)" > - depends on ATH10K && ARCH_QCOM > + depends on ATH10K > + depends on ARCH_QCOM || COMPILE_TEST > ---help--- > This module adds support for integrated WCN3990 chip > connected > to system NOC(SNOC). Currently work in progress and will not > > > Regards, > Niklas > Yes, This looks more appropriate and works well. BR, Govind