Return-path: Received: from mail.linuxfoundation.org ([140.211.169.12]:48954 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754909AbeFRHkV (ORCPT ); Mon, 18 Jun 2018 03:40:21 -0400 Date: Mon, 18 Jun 2018 09:40:18 +0200 From: Greg KH To: Kalle Valo Cc: Omer Efrat , linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org Subject: Re: [PATCH v3 5/5] staging: use BIT_ULL for NL80211_STA_INFO_* attribute types Message-ID: <20180618074018.GA17683@kroah.com> (sfid-20180618_094024_725236_0E4C72D6) References: <1529230056-18004-1-git-send-email-omer.efrat@tandemg.com> <20180617102424.GA5705@kroah.com> <87wouwa6xk.fsf@purkki.adurom.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <87wouwa6xk.fsf@purkki.adurom.net> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, Jun 18, 2018 at 10:29:43AM +0300, Kalle Valo wrote: > Greg KH writes: > > > On Sun, Jun 17, 2018 at 01:07:36PM +0300, Omer Efrat wrote: > >> The BIT macro uses unsigned long which some architectures handle as 32 bit > >> and therefore might cause macro's shift to overflow when used on a value > >> equals or larger than 32 (NL80211_STA_INFO_RX_DURATION and afterwards). > >> > >> Since 'filled' member in station_info changed to u64, BIT_ULL macro > >> should be used with all NL80211_STA_INFO_* attribute types instead of BIT > >> to prevent future possible bugs when one will use BIT macro for higher > >> attributes by mistake. > >> > >> This commit cleans up all usages of BIT macro with the above field > >> in cfg80211 by changing it to BIT_ULL instead. > >> > >> Signed-off-by: Omer Efrat > > > > Acked-by: Greg Kroah-Hartman > > Via which tree is this supposed to go? Not mine :) Have fun with it! greg k-h