Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:52400 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751898AbeFMSxj (ORCPT ); Wed, 13 Jun 2018 14:53:39 -0400 From: Kalle Valo To: John Stultz Cc: Ryan Grachek , Wei Xu , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , linux-arm-kernel , devicetree@vger.kernel.org, Linux Kernel Mailing List , Eyal Reizer , Tony Lindgren , Valentin Schneider , linux-wireless@vger.kernel.org Subject: Re: [PATCH] arm64: dts: hikey: Define wl1835 power capabilities References: <20180613151305.17240-1-ryan@edited.us> Date: Wed, 13 Jun 2018 21:53:32 +0300 In-Reply-To: (John Stultz's message of "Wed, 13 Jun 2018 11:30:00 -0700") Message-ID: <87tvq6a577.fsf@kamboji.qca.qualcomm.com> (sfid-20180613_205409_075919_B340C86C) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org List-ID: John Stultz writes: > On Wed, Jun 13, 2018 at 8:13 AM, Ryan Grachek wrote: >> These properties are required for compatibility with runtime PM. >> Without these properties, MMC host controller will not be aware >> of power capabilities. When the wlcore driver attempts to power >> on the device, it will erroneously fail with -EACCES. >> >> Signed-off-by: Ryan Grachek > > Fixes: 60f36637bbbd ("wlcore: sdio: allow pm to handle sdio power") > Tested-by: John Stultz > Acked-by: John Stultz > > Wei Xu: This fixes a functional regression with wifi on the HiKey > board that was introduced in 4.18-rc with commit 60f36637bbbd > ("wlcore: sdio: allow pm to handle sdio power"). > > Could you please be sure to queue this for the 4.18-rc ? Adding linux-wireless so that wireless folks are aware of this wlcore regression fix as well. -- Kalle Valo