Return-path: Received: from mail2.candelatech.com ([208.74.158.173]:46786 "EHLO mail2.candelatech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753760AbeFTSvp (ORCPT ); Wed, 20 Jun 2018 14:51:45 -0400 Subject: Re: [PATCH] ath10k: Don't allow tx logic when state is not ON. To: Rajkumar Manoharan References: <1529506583-20204-1-git-send-email-greearb@candelatech.com> <9ba64928-a73b-0fe6-9586-65929ca87013@codeaurora.org> <3dc5dce6-a8ef-93f6-318f-6ca2e62f8853@candelatech.com> Cc: Manikanta Pubbisetty , linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, kvalo@codeaurora.org, linux-wireless-owner@vger.kernel.org From: Ben Greear Message-ID: (sfid-20180620_205436_677761_C73B2D7B) Date: Wed, 20 Jun 2018 11:51:43 -0700 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 06/20/2018 11:48 AM, Rajkumar Manoharan wrote: > On 2018-06-20 10:42, Ben Greear wrote: >> On 06/20/2018 10:37 AM, Manikanta Pubbisetty wrote: >>> > [...] >>> This case should not be dealt in ath10k, rather we should make sure packets does not reach the driver during hardware restart after the firmware crash. >>> Can you please try the RFC patch and see if it fixes the issue? I am working on the patch and probably send it out after doing some testing and cleanup. >>> >>> https://patchwork.kernel.org/patch/10411967/ >> >> I did see your patch, but I was not sure it would make it upstream. >> >> I think either way my patch might be useful in case bugs creep back in. >> > > ar->state check can not be in hot path as it is protected by mutex lock. If the tx logic is ever called while state is changing, that would seem to be a bug as well? Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com