Return-path: Received: from gateway32.websitewelcome.com ([192.185.145.18]:15656 "EHLO gateway32.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752132AbeFAOf6 (ORCPT ); Fri, 1 Jun 2018 10:35:58 -0400 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway32.websitewelcome.com (Postfix) with ESMTP id 54F5128844 for ; Fri, 1 Jun 2018 09:23:00 -0500 (CDT) Subject: Re: [PATCH] qtnfmac: fix NULL pointer dereference To: Igor Mitsyanko , Avinash Patil , Sergey Matyukevich , Kalle Valo , "David S. Miller" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <20180601132408.GA2572@embeddedor.com> <20180601140848.czb4ws5nixuk4tjb@bars> From: "Gustavo A. R. Silva" Message-ID: <14b57d7b-15cf-dfd8-d64c-2200d435d2f6@embeddedor.com> (sfid-20180601_163942_825874_8CF619CB) Date: Fri, 1 Jun 2018 09:22:28 -0500 MIME-Version: 1.0 In-Reply-To: <20180601140848.czb4ws5nixuk4tjb@bars> Content-Type: text/plain; charset=utf-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi Sergey, On 06/01/2018 09:08 AM, Sergey Matyukevich wrote: > Hello Gustavo, > >> diff --git a/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c b/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c >> index 220e2b7..ae0ca80 100644 >> --- a/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c >> +++ b/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c >> @@ -654,8 +654,7 @@ qtnf_disconnect(struct wiphy *wiphy, struct net_device *dev, >> vif = qtnf_mac_get_base_vif(mac); >> if (!vif) { >> pr_err("MAC%u: primary VIF is not configured\n", mac->macid); >> - ret = -EFAULT; >> - goto out; >> + return -EFAULT; >> } >> >> if (vif->wdev.iftype != NL80211_IFTYPE_STATION) { > > That was my fault. Thanks for the fix! > Glad to help. :) > Reviewed-by: Sergey Matyukevich > Thanks -- Gustavo