Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:51968 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753760AbeFTSsE (ORCPT ); Wed, 20 Jun 2018 14:48:04 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Date: Wed, 20 Jun 2018 11:48:03 -0700 From: Rajkumar Manoharan To: Ben Greear Cc: Manikanta Pubbisetty , linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, kvalo@codeaurora.org, linux-wireless-owner@vger.kernel.org Subject: Re: [PATCH] ath10k: Don't allow tx logic when state is not ON. In-Reply-To: <3dc5dce6-a8ef-93f6-318f-6ca2e62f8853@candelatech.com> References: <1529506583-20204-1-git-send-email-greearb@candelatech.com> <9ba64928-a73b-0fe6-9586-65929ca87013@codeaurora.org> <3dc5dce6-a8ef-93f6-318f-6ca2e62f8853@candelatech.com> Message-ID: (sfid-20180620_204808_437166_A35FEACD) Sender: linux-wireless-owner@vger.kernel.org List-ID: On 2018-06-20 10:42, Ben Greear wrote: > On 06/20/2018 10:37 AM, Manikanta Pubbisetty wrote: >> [...] >> This case should not be dealt in ath10k, rather we should make sure >> packets does not reach the driver during hardware restart after the >> firmware crash. >> Can you please try the RFC patch and see if it fixes the issue? I am >> working on the patch and probably send it out after doing some testing >> and cleanup. >> >> https://patchwork.kernel.org/patch/10411967/ > > I did see your patch, but I was not sure it would make it upstream. > > I think either way my patch might be useful in case bugs creep back in. > ar->state check can not be in hot path as it is protected by mutex lock. -Rajkumar