Return-path: Received: from mail-wm0-f65.google.com ([74.125.82.65]:38226 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752576AbeFYIqN (ORCPT ); Mon, 25 Jun 2018 04:46:13 -0400 Received: by mail-wm0-f65.google.com with SMTP id 69-v6so8981505wmf.3 for ; Mon, 25 Jun 2018 01:46:13 -0700 (PDT) MIME-Version: 1.0 References: <1529693004-20569-1-git-send-email-arend.vanspriel@broadcom.com> <5B30A85C.5080105@broadcom.com> In-Reply-To: <5B30A85C.5080105@broadcom.com> From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Date: Mon, 25 Jun 2018 10:43:55 +0200 Message-ID: (sfid-20180625_104704_599053_8B779090) Subject: Re: [PATCH 0/6] brcmfmac: fix 160MHz support and monitor mode To: Arend Van Spriel Cc: Kalle Valo , "linux-wireless@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, 25 Jun 2018 at 10:31, Arend van Spriel wrote: > > On 6/25/2018 6:40 AM, Rafa=C5=82 Mi=C5=82ecki wrote: > > On Sun, 24 Jun 2018 at 13:48, Rafa=C5=82 Mi=C5=82ecki wrote: > >> On Fri, 22 Jun 2018 at 20:45, Arend van Spriel > >> wrote: > >>> Here a couple of patches in preparation of monitor mode support. It > >>> is mostly about querying firmware for support. While at it I stumbled > >>> upon the fact that 160MHz was not completely implemented in the drive= r > >>> so there is a patch for that as well. > >>> > >>> The first two patches are actually some changes to the patches that > >>> Rafal submitted. So this series depend on: > >>> > >>> [V3,2/2] brcmfmac: handle monitor mode marked msgbuf packets [1] > >>> > >>> These apply to the master branch of the wireless-drivers-next reposit= ory. > >>> > >>> [1] https://patchwork.kernel.org/patch/10474799/ > >> > >> I find it pointless to submit fixes for patches that weren't accepted > >> yet. Let's work on improving original patches while they are still > >> pending. > > > > I sent V4 with changes pointed our by Arend. That obsoletes all (?) > > monitor patches from this patchset. I believe it was cleaner to > > improve original patchset (not pushed yet). > > > > My suggestion is to apply patches 3/6 and 4/6 (they aren't monitor > > related) and drop the others. > > Well. Given that Kalle prefers applying "all-or-nothing" I will resubmit > the series addressing the issues you found. I wasn't aware of this, good to know, thanks! --=20 Rafa=C5=82