Subject: Re: [PATCH 00/23] staging: wilc1000: cleanup patch to follow linux
 coding style
To: Ajay Singh <ajay.kathat@microchip.com>,
        <linux-wireless@vger.kernel.org>
CC: <devel@driverdev.osuosl.org>, <gregkh@linuxfoundation.org>,
        <ganesh.krishna@microchip.com>, <venkateswara.kaja@microchip.com>,
        <aditya.shankar@microchip.com>, <adham.abozaeid@microchip.com>
References: <1531953919-20804-1-git-send-email-ajay.kathat@microchip.com>
From: Claudiu Beznea <Claudiu.Beznea@microchip.com>
Message-ID: <4645c136-eaad-01a9-cebe-abff6f4dce3e@microchip.com> (sfid-20180719_103700_799543_6023B27B)
Date: Thu, 19 Jul 2018 11:36:45 +0300
MIME-Version: 1.0
In-Reply-To: <1531953919-20804-1-git-send-email-ajay.kathat@microchip.com>
Content-Type: text/plain; charset="utf-8"
Sender: linux-wireless-owner@vger.kernel.org

Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>


On 19.07.2018 01:44, Ajay Singh wrote:
> This patch series contains modification to follow Linux coding style &
> cleanup change to remove unused variables and enums.
> Few patches also contain changes to remove unnecessary typecast.
> 
> Ajay Singh (23):
>   staging: wilc1000: remove unused enum declaration
>   staging: wilc1000: remove enum connect_status instead use
>     ieee80211_statuscode
>   staging: wilc1000: remove extra enum defined for data rates
>   staging: wilc1000: remove extra enums defined for ieee80211_eid
>   staging: wilc1000: rename goto to avoid leading '_' in label name
>   staging: wilc1000: rename enum CURRENT_TXRATE to use lowercase
>   staging: wilc1000: rename enum SITESURVEY to use lowercase
>   staging: wilc1000: rename enum AUTHTYPE to use lowercase
>   staging: wilc1000: remove unused elements in 'wilc' struct
>   staging: wilc1000: remove unnecessary elements from 'wilc_priv' struct
>   staging: wilc1000: removed unused element from wilc_cfg_frame struct
>   staging: wilc1000: remove the mutliple #define used for same macro
>   staging: wilc1000: use lowercase for 'IFC_UP' struct element name
>   staging: wilc1000: remove unnecessary blank line between variable
>     declaration
>   staging: wilc1000: use single space before opening brances '{'
>   staging: wilc1000: remove unnecessary type used for wid id
>   staging: wilc1000: avoid forward declaration for handle_scan_done()
>   staging: wilc1000: avoid host_int_get_assoc_res_info() forward
>     declaration
>   staging: wilc1000: avoid forward declaration of
>     host_int_parse_join_bss_param()
>   staging: wilc1000: avoid setting default value for variable at
>     declaration
>   staging: wilc1000: use 'int' inplace of 's32' date type
>   staging: wilc1000: remove unnecessary 'NULL' check from cfg80211_ops
>     callbacks
>   staging: wilc1000: move variable assignment along with its declaration
> 
>  drivers/staging/wilc1000/coreconfigurator.c       |  84 +--
>  drivers/staging/wilc1000/coreconfigurator.h       |  20 -
>  drivers/staging/wilc1000/host_interface.c         | 696 +++++++++++-----------
>  drivers/staging/wilc1000/host_interface.h         |  20 +-
>  drivers/staging/wilc1000/linux_mon.c              |   2 -
>  drivers/staging/wilc1000/linux_wlan.c             | 122 ++--
>  drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 307 +++-------
>  drivers/staging/wilc1000/wilc_wfi_netdevice.h     |  16 +-
>  drivers/staging/wilc1000/wilc_wlan.c              |  65 +-
>  drivers/staging/wilc1000/wilc_wlan.h              |   3 -
>  drivers/staging/wilc1000/wilc_wlan_if.h           |  56 +-
>  11 files changed, 517 insertions(+), 874 deletions(-)
>