Return-path: <linux-wireless-owner@vger.kernel.org>
Received: from foss.arm.com ([217.140.101.70]:51782 "EHLO foss.arm.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S933157AbeGCQB1 (ORCPT <rfc822;linux-wireless@vger.kernel.org>);
        Tue, 3 Jul 2018 12:01:27 -0400
Date: Tue, 3 Jul 2018 17:01:22 +0100
From: Mark Rutland <mark.rutland@arm.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Brian Norris <briannorris@chromium.org>,
        Govind Singh <govinds@codeaurora.org>,
        devicetree@vger.kernel.org, linux-wireless@vger.kernel.org,
        ath10k@lists.infradead.org, bjorn.andersson@linaro.org,
        david.brown@linaro.org, Rob Herring <robh+dt@kernel.org>,
        andy.gross@linaro.org
Subject: Re: [PATCH v2 3/6] dt: bindings: add bindings for msa memory region
Message-ID: <20180703160122.w54lq7mr2uectjea@lakrids.cambridge.arm.com> (sfid-20180703_180137_401885_6E668AFD)
References: <20180605123616.528-1-govinds@codeaurora.org>
 <20180605231814.GB194157@rodete-desktop-imager.corp.google.com>
 <87o9fonx5r.fsf@kamboji.qca.qualcomm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
In-Reply-To: <87o9fonx5r.fsf@kamboji.qca.qualcomm.com>
Sender: linux-wireless-owner@vger.kernel.org
List-ID: <linux-wireless.vger.kernel.org>

On Tue, Jul 03, 2018 at 06:42:24PM +0300, Kalle Valo wrote:
> Brian Norris <briannorris@chromium.org> writes:
> 
> > + Rob
> >
> > On Tue, Jun 05, 2018 at 06:06:16PM +0530, Govind Singh wrote:
> >> Add device tree binding documentation details of msa
> >> memory region for ath10k qmi client for SDM845/APQ8098
> >> SoC into "qcom,ath10k.txt".
> >> 
> >> Signed-off-by: Govind Singh <govinds@codeaurora.org>
> >> ---
> >>  .../devicetree/bindings/net/wireless/qcom,ath10k.txt          | 4 ++++
> >>  1 file changed, 4 insertions(+)
> >> 
> >> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> >> index 7fd4e8ce4149..0efc47f4ba34 100644
> >> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> >> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> >> @@ -56,6 +56,8 @@ Optional properties:
> >>  				     the length can vary between hw versions.
> >>  - <supply-name>-supply: handle to the regulator device tree node
> >>  			   optional "supply-name" is "vdd-0.8-cx-mx".
> >> +- msa-fixed-region: phandle, specifier to children of reserved MSA memory.
> >
> > As in reserved-memory/reserved-memory.txt? Might refer to that doc here.
> > Or is this some other kind of reserved memory?
> >
> > If the former, it's normally called just "memory-region", although
> > that does seem somewhat non-descriptive...
> >
> >> +- msa-size: MSA memory size for fw internal use.
> >
> > Do you really need both of these? It seems like your code uses one or
> > the other, not both. In which case, this is not a very good description,
> > because it sounds like they would go together.
> >
> > Also, if you're not using standard/generic properties (e.g., the
> > aforementioned "memory-region" binding), you typically should use a
> > vendor prefix, like "qcom,msa-size".
> 
> Devicetree folks, any comments? I would like to apply this via my
> ath.git tree but need help with the review.

I think Brian's comments w.r.t msa-size and msa-fixed-region both stand.
It would be good if Govind could answer his questions.

Thanks,
Mark.