Return-path: Received: from mail.bugwerft.de ([46.23.86.59]:49898 "EHLO mail.bugwerft.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388071AbeGWPB5 (ORCPT ); Mon, 23 Jul 2018 11:01:57 -0400 From: Daniel Mack To: sameo@linux.intel.com Cc: linux-wireless@vger.kernel.org, colin.king@canonical.com, shikha.singh@st.com, Daniel Mack Subject: [PATCH 03/10] NFC: st95hf: drop illegal kfree_skb() in IRQ handler Date: Mon, 23 Jul 2018 16:00:08 +0200 Message-Id: <20180723140015.11663-4-daniel@zonque.org> (sfid-20180723_160036_509725_4C995DE7) In-Reply-To: <20180723140015.11663-1-daniel@zonque.org> References: <20180723140015.11663-1-daniel@zonque.org> Sender: linux-wireless-owner@vger.kernel.org List-ID: In the error path of the IRQ handler, don't free the skb in flight. The callback in the digital core will do that for us. Doing it from both places causes memory corruptions. Signed-off-by: Daniel Mack --- drivers/nfc/st95hf/core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/nfc/st95hf/core.c b/drivers/nfc/st95hf/core.c index d58424ab5c48..d857197ec7b2 100644 --- a/drivers/nfc/st95hf/core.c +++ b/drivers/nfc/st95hf/core.c @@ -863,7 +863,6 @@ static irqreturn_t st95hf_irq_thread_handler(int irq, void *st95hfcontext) return IRQ_HANDLED; end: - kfree_skb(skb_resp); wtx = false; cb_arg->rats = false; skb_resp = ERR_PTR(result); -- 2.17.1