Return-path: Received: from mail.toke.dk ([52.28.52.200]:47877 "EHLO mail.toke.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726264AbeGRTGj (ORCPT ); Wed, 18 Jul 2018 15:06:39 -0400 From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Jean-Pierre TOSONI , Ben Greear , SEDE , Benjamin Beichler , ath10k , "linux-wireless\@vger.kernel.org" Subject: RE: Setting tx retry count in ath10k In-Reply-To: References: <8b9713fe-7573-f009-d002-13df73315898@televic.com> <9dd76e58-b514-26f2-2fe9-0c9a7f798054@candelatech.com> <877els5xax.fsf@toke.dk> Date: Wed, 18 Jul 2018 20:27:17 +0200 Message-ID: <871sc05ri2.fsf@toke.dk> (sfid-20180718_202734_578427_C3F0A943) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org List-ID: Jean-Pierre TOSONI writes: > @Toke: As you can see in the patch, the value 30 was the fixed value > defined in ath9k, I kept it for compatibility only (and that's why I > wanted to make it configurable :-) Yup, I'm aware that this is the default from ath9k; doesn't make it any less wrong ;) > On another hand, Minstrel in mac80211 seems to vary retries according > to what you say, i.e. Minstrel tries to stay below a certain amount of > time, but this only applies to short/long retries. Right, haven't had time to poke into what exactly Minstrel does; have just observed that it sometimes runs really long. But for most cases it's not too bad... -Toke