Return-path: Received: from mail-wr1-f65.google.com ([209.85.221.65]:38679 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729780AbeGMIBE (ORCPT ); Fri, 13 Jul 2018 04:01:04 -0400 Received: by mail-wr1-f65.google.com with SMTP id m1-v6so11383488wrg.5 for ; Fri, 13 Jul 2018 00:47:37 -0700 (PDT) Subject: Re: [PATCH 11/18] wireless/ti: change strncpy+truncation to strlcpy To: Greg Kroah-Hartman , Dominique Martinet References: <1531444483-17338-1-git-send-email-asmadeus@codewreck.org> <1531445149-19607-1-git-send-email-asmadeus@codewreck.org> <20180713073810.GA31984@kroah.com> Cc: Kalle Valo , "David S. Miller" , Thomas Gleixner , Kate Stewart , Philippe Ombredanne , Joe Perches , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org From: Arend van Spriel Message-ID: <5B485917.7090102@broadcom.com> (sfid-20180713_094753_014520_457EEDA1) Date: Fri, 13 Jul 2018 09:47:35 +0200 MIME-Version: 1.0 In-Reply-To: <20180713073810.GA31984@kroah.com> Content-Type: text/plain; charset=windows-1252; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 7/13/2018 9:38 AM, Greg Kroah-Hartman wrote: > On Fri, Jul 13, 2018 at 03:25:49AM +0200, Dominique Martinet wrote: >> Generated by scripts/coccinelle/misc/strncpy_truncation.cocci >> >> Signed-off-by: Dominique Martinet > > I don't know about other maintainers, but I know I wouldn't take such a > horrid changelog description as this :) > > good luck! especially as that script is not in the kernel tree yet. The patch adding that script contains a good motivation, but I would want to see that in commit message of every patch or at least the gist of it. Regards, Arend