Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:43442 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727020AbeGaJ33 (ORCPT ); Tue, 31 Jul 2018 05:29:29 -0400 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Subject: Re: [PATCH] net: wireless: ath6kl: Replace GFP_ATOMIC with GFP_KERNEL in ath6kl_bmi_init() From: Kalle Valo In-Reply-To: <20180727084318.3345-1-baijiaju1990@gmail.com> References: <20180727084318.3345-1-baijiaju1990@gmail.com> To: Jia-Ju Bai Cc: kvalo@qca.qualcomm.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jia-Ju Bai Message-Id: <20180731075027.1FA2D6071C@smtp.codeaurora.org> (sfid-20180731_095151_139006_27302497) Date: Tue, 31 Jul 2018 07:50:27 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org List-ID: Jia-Ju Bai wrote: > ath6kl_bmi_init() is never called in atomic context. > It calls kzalloc() with GFP_ATOMIC, which is not necessary. > GFP_ATOMIC can be replaced with GFP_KERNEL. > > This is found by a static analysis tool named DCNS written by myself. > > Signed-off-by: Jia-Ju Bai > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. bfc55fe65987 ath6kl: replace GFP_ATOMIC with GFP_KERNEL in ath6kl_bmi_init() -- https://patchwork.kernel.org/patch/10546741/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches