Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:39644 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752341AbeGBO5z (ORCPT ); Mon, 2 Jul 2018 10:57:55 -0400 From: Kalle Valo To: Daniel Mack Cc: Ulf Hansson , Chris Ball , "linux-mmc\@vger.kernel.org" , libertas-dev@lists.infradead.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH v2] libertas: fix suspend and resume for SDIO connected cards References: <20180627185845.31799-1-daniel@zonque.org> Date: Mon, 02 Jul 2018 17:57:51 +0300 In-Reply-To: (Daniel Mack's message of "Fri, 29 Jun 2018 19:57:45 +0200") Message-ID: <87o9fp8z2o.fsf@purkki.adurom.net> (sfid-20180702_165802_747258_58612496) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-wireless-owner@vger.kernel.org List-ID: Daniel Mack writes: > On Friday, June 29, 2018 05:39 PM, Ulf Hansson wrote: >> On 27 June 2018 at 20:58, Daniel Mack wrote: >>> Prior to commit 573185cc7e64 ("mmc: core: Invoke sdio func driver's PM >>> callbacks from the sdio bus"), the MMC core used to call into the power >>> management functions of SDIO clients itself and removed the card if the >>> return code was non-zero. IOW, the mmc handled errors gracefully and didn't >>> upchain them to the pm core. >>> >>> Since this change, the mmc core relies on generic power management >>> functions which treat all errors as a reason to cancel the suspend >>> immediately. This causes suspend attempts to fail when the libertas >>> driver is loaded. >>> >>> To fix this, power down the card explicitly in if_sdio_suspend() when we >>> know we're about to lose power and return success. Also set a flag in these >>> cases, and power up the card again in if_sdio_resume(). >>> >>> Signed-off-by: Daniel Mack >>> Cc: Ulf Hansson >>> Cc: Chris Ball >> >> Looks good to me! Should be a candidate for stable as well!? > > Thanks! > > Yeah, it should probably get a > > Fixes: 573185cc7e64 ("mmc: core: Invoke sdio func driver's PM > callbacks from the sdio bus") > > as well. So I'll queue this for wireless-drivers-next and add: Fixes: 573185cc7e64 ("mmc: core: Invoke sdio func driver's PM callbacks from the sdio bus") Cc: