Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:53570 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728872AbeHaTqM (ORCPT ); Fri, 31 Aug 2018 15:46:12 -0400 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Subject: Re: [PATCH] b43: Fix regression in kernel 4.18 From: Kalle Valo In-Reply-To: <20180827153407.5612-1-Larry.Finger@lwfinger.net> References: <20180827153407.5612-1-Larry.Finger@lwfinger.net> To: Larry Finger Cc: linux-wireless@vger.kernel.org, Larry Finger , Stable , Taketo Kabe Message-Id: <20180831153808.EFDCF6038E@smtp.codeaurora.org> (sfid-20180831_173828_701325_B9091411) Date: Fri, 31 Aug 2018 15:38:08 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org List-ID: Larry Finger wrote: > In commit 66cffd6daab7 ("b43: fix transmit failure when VT is switched"), > a condition is noted where the network controller needs to be reset. Note > that this situation happens when running the open-source firmware > (http://netweb.ing.unibs.it/~openfwwf/), plus a number of other special > conditions. > > for a different card model, it is reported that this change breaks > operation running the proprietary firmware > (https://marc.info/?l=linux-wireless&m=153504546924558&w=2). Rather > than reverting the previous patch, the code is tweaked to avoid the > reset unless the open-source firmware is being used. > > Fixes: 66cffd6daab7 ("b43: fix transmit failure when VT is switched") > Cc: Stable # 4.18+ > Cc: Taketo Kabe > Reported-and-tested-by: D. Prabhu > Signed-off-by: Larry Finger I'll change the title to something more descriptive: b43: fix DMA error related regression with proprietary firmware Does that make sense? -- https://patchwork.kernel.org/patch/10577379/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches