Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:59390 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730839AbeHISlD (ORCPT ); Thu, 9 Aug 2018 14:41:03 -0400 From: Kalle Valo To: Jonas Gorski Cc: Michael =?utf-8?Q?B=C3=BCsch?= , Larry Finger , =?utf-8?Q?Rafa=C5=82_Mi=C5=82ecki?= , linux-wireless , b43-dev Subject: Re: b43/leds: Ensure NUL-termination of LED name string References: <20180731211404.2eac1bb0@wiggum> <87lg9f1rw8.fsf@kamboji.qca.qualcomm.com> Date: Thu, 09 Aug 2018 19:15:22 +0300 In-Reply-To: (Jonas Gorski's message of "Thu, 9 Aug 2018 18:02:06 +0200") Message-ID: <87mutvzfc5.fsf@kamboji.qca.qualcomm.com> (sfid-20180809_181556_350829_CCD5B7AC) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: Jonas Gorski writes: > On 9 August 2018 at 17:28, Kalle Valo wrote: >> Michael B=C3=BCsch writes: >> >>> strncpy might not NUL-terminate the string, if the name equals the buff= er size. >>> Use strlcpy instead. >>> >>> Signed-off-by: Michael Buesch >>> Cc: stable@vger.kernel.org >> >> This is weird, with all the patches you submitted last week I get this >> if I download the patch from patchwork: >> >> $ git am -s 1.mbox >> Patch is empty. Was it split wrong? >> >> But if I download the patch directly from my IMAP folder I have no >> problems: >> >> $ git am -s 1.mbox >> Applying: b43/leds: Ensure NUL-termination of LED name string >> >> This happens even without my custom patchwork script so this has >> something to do with the patchwork server, but it's not obvious to me >> what triggers it. IIRC I have not seen anything like this before. It >> seems that you didn't use git-send-email, I strongly suggest to use that >> just to avoid problems like this. > > Looks like patchwork mishandles the pgp signature, the patchwork mbox has > >> Content-Type: multipart/signed; micalg=3Dpgp-sha512; >> boundary=3D"Sig_/EN90ciRq4eWXDUcnZABQ0Ak"; protocol=3D"application/pgp-= signature" > > as the only content-type (and the boundary is nowhere to be found), > while the one in my inbox has > >> Content-Type: multipart/signed; micalg=3Dpgp-sha512; >> boundary=3D"Sig_/EN90ciRq4eWXDUcnZABQ0Ak"; >> protocol=3D"application/pgp-signature" >> >> --Sig_/EN90ciRq4eWXDUcnZABQ0Ak >> Content-Type: text/plain; charset=3DUS-ASCII >> Content-Transfer-Encoding: quoted-printable > > When I remove the Content-Type: line(s) from the mbox from patchwork, > git recognises it again as a patch. I guess git am ignores everything > until the boundary, which got dropped by patchwork, so it never finds > the actual patch. Awesome, thanks for debugging this! It would be great if someone could report this to the patchwork maintainers, I don't have the time right now. --=20 Kalle Valo