Return-path: Received: from mail.linuxfoundation.org ([140.211.169.12]:42894 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726773AbeHLJTu (ORCPT ); Sun, 12 Aug 2018 05:19:50 -0400 Date: Sun, 12 Aug 2018 08:42:50 +0200 From: Greg KH To: Ajay Singh Cc: linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org, venkateswara.kaja@microchip.com, ganesh.krishna@microchip.com, adham.abozaeid@microchip.com, aditya.shankar@microchip.com Subject: Re: [PATCH 2/5] staging: wilc1000: fixes for undefined reference to `__this_module' error Message-ID: <20180812064250.GA31152@kroah.com> (sfid-20180812_084321_053480_53B2ACFE) References: <1534049265-5600-1-git-send-email-ajay.kathat@microchip.com> <1534049265-5600-3-git-send-email-ajay.kathat@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1534049265-5600-3-git-send-email-ajay.kathat@microchip.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Sun, Aug 12, 2018 at 10:17:42AM +0530, Ajay Singh wrote: > wilc_debug.o object file is included for both SDIO and SPI module. When > anyone(either SDIO or SPI) module is compiled as loaded module and another > as buildin module then below compilation error occurs. > > "drivers/staging/wilc1000/wilc_debugfs.o:(.data+0x10): undefined > reference to `__this_module'" > > Moved the declaration of file_operation variable in SDIO/SPI files and > pass this as parameter to wilc_debugfs_init(). Remove 'fops' element > from 'wilc_debugfs_info_t' struct, as its not required. > > Fixes: 9abc44ba4e2f ("staging: wilc1000: fix TODO to compile spi and sdio components in single module") > Reported-by: kbuild test robot > Signed-off-by: Ajay Singh > --- Can this be the first patch in the series so it can go to Linus for 4.19 and the rest can be postponed for later? thanks, greg k-h