Return-path: Received: from mail-oi0-f66.google.com ([209.85.218.66]:46197 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726197AbeHTWFW (ORCPT ); Mon, 20 Aug 2018 18:05:22 -0400 Received: by mail-oi0-f66.google.com with SMTP id y207-v6so27605412oie.13 for ; Mon, 20 Aug 2018 11:48:35 -0700 (PDT) From: Larry Finger To: kvalo@codeaurora.org Cc: linux-wireless@vger.kernel.org, Larry Finger Subject: [PATCH] rtl8187: Fix warning generated when strncpy() destination length matches the sixe argument Date: Mon, 20 Aug 2018 13:48:31 -0500 Message-Id: <20180820184831.24206-1-Larry.Finger@lwfinger.net> (sfid-20180820_204838_651531_48C3F931) Sender: linux-wireless-owner@vger.kernel.org List-ID: In gcc8, when the 3rd argument (size) of a call to strncpy() matches the length of the first argument, the compiler warns of the possibility of an unterminated string. Using strlcpy() forces a null at the end. Signed-off-by: Larry Finger --- drivers/net/wireless/realtek/rtl818x/rtl8187/leds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtl818x/rtl8187/leds.c b/drivers/net/wireless/realtek/rtl818x/rtl8187/leds.c index c2d5b495c179..c089540116fa 100644 --- a/drivers/net/wireless/realtek/rtl818x/rtl8187/leds.c +++ b/drivers/net/wireless/realtek/rtl818x/rtl8187/leds.c @@ -146,7 +146,7 @@ static int rtl8187_register_led(struct ieee80211_hw *dev, led->dev = dev; led->ledpin = ledpin; led->is_radio = is_radio; - strncpy(led->name, name, sizeof(led->name)); + strlcpy(led->name, name, sizeof(led->name)); led->led_dev.name = led->name; led->led_dev.default_trigger = default_trigger; -- 2.18.0