Return-path: Received: from mail-qt0-f182.google.com ([209.85.216.182]:45328 "EHLO mail-qt0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726528AbeHQLXi (ORCPT ); Fri, 17 Aug 2018 07:23:38 -0400 Received: by mail-qt0-f182.google.com with SMTP id y5-v6so7882842qti.12 for ; Fri, 17 Aug 2018 01:21:11 -0700 (PDT) Subject: Re: feedback on mainlining wilc1000 staging driver To: Kalle Valo , Ajay Singh References: <20180816015243.545cd009@ajaysk-VirtualBox> <87sh3etwoj.fsf@purkki.adurom.net> <87o9e2twe9.fsf@purkki.adurom.net> <20180817100233.7f1c00d9@ajaysk-VirtualBox> <8736vdv3f5.fsf@kamboji.qca.qualcomm.com> Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, linux-wireless@vger.kernel.org, nicolas.ferre@microchip.com, ganesh.krishna@microchip.com, adham.abozaeid@microchip.com, aditya.shankar@microchip.com From: Arend van Spriel Message-ID: <5B768574.6060009@broadcom.com> (sfid-20180817_102227_504714_4C8C4385) Date: Fri, 17 Aug 2018 10:21:08 +0200 MIME-Version: 1.0 In-Reply-To: <8736vdv3f5.fsf@kamboji.qca.qualcomm.com> Content-Type: text/plain; charset=utf-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 8/17/2018 9:49 AM, Kalle Valo wrote: > Ajay Singh writes: > >> On Thu, 16 Aug 2018 13:53:50 +0300 >> Kalle Valo wrote: >> >>> Kalle Valo writes: >>> >>>> Ajay Singh writes: >>>> >>>>> Hi Greg, >>>>> >>>>> We all are working on submitting and reviewing patches for >>>>> wilc1000 in staging driver for quite some time. >>>>> >>>>> We would like to have feedback on the next steps to bring wilc1000 >>>>> driver closer to move into the wireless subsystem tree. >>>>> >>>>> In summary, the following major things from TODO have been >>>>> addressed in staging: >>>>> -remove the defined feature as kernel versions >>>>> -remove OS wrapper functions >>>>> -remove custom debug and tracing functions >>>>> -rework comments and function headers(also coding style) >>>>> -remove build warnings >>>>> -replace all semaphores with mutexes or completions >>>>> -make spi and sdio components coexist in one build >>>>> -turn compile-time platform configuration (BEAGLE_BOARD, >>>>> PANDA_BOARD, PLAT_WMS8304, PLAT_RKXXXX, CUSTOMER_PLATFORM, ...) >>>>> into run-time options that are read from DT >>>>> -replace SIOCDEVPRIVATE commands with generic API functions >>>>> -use wext-core handling instead of private SIOCSIWPRIV >>>>> implementation >>>> >>>> From wireless point of view: if I see wext mentioned anywhere in the >>>> driver I stop right there. cfg80211 is a hard requirement for us >>>> nowadays. >>> >>> Clarification: Depending on the hardware design either cfg80211 or >>> mac80211 is a hard requirement. I haven't checked wilc1000 at all so I >>> don't know what design it has but if it's a "softmac" design then it >>> has to use mac80211, we do not want to support multiple 802.11 UMAC >>> stacks. >>> >> >> The TODO item to make use of wext-core is obsolete. Previously wilc1000 >> driver also had few wext ioctl use but now it’s completely removed and >> cfg80211 operation callbacks are used. >> >> wilc1000 driver make use of cfg80211 and isn’t a "softmac". > > Good. > >> We need help to review and identify if there are any pending items >> for wilc1000 driver, so we can address those issues and make it ready >> to move to the wireless subsystem. > > I think the best way to get that forward is to submit a patch (or > patchset) to linux-wireless, that's the easiest for reviewers. For brcm80211 drivers we used a single patch introducing it under the wireless drivers folder. Because it was quite a sizable patch we parked it on the wireless wiki page. Had a few iterations doing it like that. Regards, Arend