Return-path: Received: from mail-wm0-f67.google.com ([74.125.82.67]:34125 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725868AbeIEPg3 (ORCPT ); Wed, 5 Sep 2018 11:36:29 -0400 Received: by mail-wm0-f67.google.com with SMTP id j25-v6so13680561wmc.1 for ; Wed, 05 Sep 2018 04:06:44 -0700 (PDT) Subject: Re: [PATCH 0/6] brcmfmac: fix 160MHz support and monitor mode To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= References: <1529693004-20569-1-git-send-email-arend.vanspriel@broadcom.com> <5B30A85C.5080105@broadcom.com> Cc: Kalle Valo , "linux-wireless@vger.kernel.org" From: Arend van Spriel Message-ID: <5B8FB8C2.2040200@broadcom.com> (sfid-20180905_130647_950387_E38870A4) Date: Wed, 5 Sep 2018 13:06:42 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 8/29/2018 10:17 PM, Rafał Miłecki wrote: > Hi Arend, > > On Mon, 25 Jun 2018 at 10:31, Arend van Spriel > wrote: >> On 6/25/2018 6:40 AM, Rafał Miłecki wrote: >>> On Sun, 24 Jun 2018 at 13:48, Rafał Miłecki wrote: >>>> On Fri, 22 Jun 2018 at 20:45, Arend van Spriel >>>> wrote: >>>>> Here a couple of patches in preparation of monitor mode support. It >>>>> is mostly about querying firmware for support. While at it I stumbled >>>>> upon the fact that 160MHz was not completely implemented in the driver >>>>> so there is a patch for that as well. >>>>> >>>>> The first two patches are actually some changes to the patches that >>>>> Rafal submitted. So this series depend on: >>>>> >>>>> [V3,2/2] brcmfmac: handle monitor mode marked msgbuf packets [1] >>>>> >>>>> These apply to the master branch of the wireless-drivers-next repository. >>>>> >>>>> [1] https://patchwork.kernel.org/patch/10474799/ >>>> >>>> I find it pointless to submit fixes for patches that weren't accepted >>>> yet. Let's work on improving original patches while they are still >>>> pending. >>> >>> I sent V4 with changes pointed our by Arend. That obsoletes all (?) >>> monitor patches from this patchset. I believe it was cleaner to >>> improve original patchset (not pushed yet). >>> >>> My suggestion is to apply patches 3/6 and 4/6 (they aren't monitor >>> related) and drop the others. >> >> Well. Given that Kalle prefers applying "all-or-nothing" I will resubmit >> the series addressing the issues you found. > > Would you have a moment to resubmit these 2 patches or do you mind if I do that? Found a moment. Should be in patchwork now. Regards, Arend