Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:48876 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726108AbeIDQIN (ORCPT ); Tue, 4 Sep 2018 12:08:13 -0400 From: Kalle Valo To: Wen Gong Cc: Wen Gong , "linux-wireless\@vger.kernel.org" , "ath10k\@lists.infradead.org" Subject: Re: [EXTERNAL] Re: [PATCH v3] ath10k: support NET_DETECT WoWLAN feature References: <1534402113-14337-1-git-send-email-wgong@codeaurora.org> <877ek18vyn.fsf@kamboji.qca.qualcomm.com> Date: Tue, 04 Sep 2018 14:43:23 +0300 In-Reply-To: (Wen Gong's message of "Tue, 4 Sep 2018 11:18:25 +0000") Message-ID: <87zhwx7ajo.fsf@kamboji.qca.qualcomm.com> (sfid-20180904_134333_133715_DC23043F) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org List-ID: Wen Gong writes: >> > +enum wmi_nlo_cipher_algorithm { >> > + WMI_NLO_CIPHER_ALGO_NONE = 0x00, >> > + WMI_NLO_CIPHER_ALGO_WEP40 = 0x01, >> > + WMI_NLO_CIPHER_ALGO_TKIP = 0x02, >> > + WMI_NLO_CIPHER_ALGO_CCMP = 0x04, >> > + WMI_NLO_CIPHER_ALGO_WEP104 = 0x05, >> > + WMI_NLO_CIPHER_ALGO_BIP = 0x06, >> > + WMI_NLO_CIPHER_ALGO_WPA_USE_GROUP = 0x100, >> > + WMI_NLO_CIPHER_ALGO_RSN_USE_GROUP = 0x100, >> >> Two defines with the same value 0x100, is this really correct? > > Yes, it is an interface between host driver /firmware. Yeah, I know it's an interface between the host driver and the firmware but it does not make any sense and is just confusing. Either of them should be dropped. -- Kalle Valo