Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:53188 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727490AbeIEJTW (ORCPT ); Wed, 5 Sep 2018 05:19:22 -0400 From: Kalle Valo To: Balaji Pothunoori Cc: johannes@sipsolutions.net, ath10k@lists.infradead.org, linux-wireless@vger.kernel.org Subject: Re: [PATCHv2 3/3] ath10k: average ack rssi support for data frames References: <1523890122-23952-1-git-send-email-bpothuno@codeaurora.org> <1523890122-23952-4-git-send-email-bpothuno@codeaurora.org> Date: Wed, 05 Sep 2018 07:50:25 +0300 In-Reply-To: <1523890122-23952-4-git-send-email-bpothuno@codeaurora.org> (Balaji Pothunoori's message of "Mon, 16 Apr 2018 20:18:42 +0530") Message-ID: <87r2i87dke.fsf@kamboji.qca.qualcomm.com> (sfid-20180905_065154_171799_ACDCF0D6) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org List-ID: Balaji Pothunoori writes: > Average ack rssi value is weighted average of ack rssi for > no of msdu's has been sent. > This feature is enabled by the host driver if firmware is capable. > After receiving event from host, firmware allocates the necessary > memory to store the ack_rssi for data packets during the init time. > > After each successful transmission, If tx completion status is OK > and 24th bit is set in HTT message header then host will fetch the > ack_rssi else host can ignore the ack_rssi field. > > Signed-off-by: Balaji Pothunoori There were two new warnings: drivers/net/wireless/ath/ath10k/htt_rx.c:1928: line over 90 characters drivers/net/wireless/ath/ath10k/mac.c:8511: Alignment should match open parenthesis I fixed those in the pending branch. The first one I solved by adding a temporary variable 'msdus'. Please review: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=e4ac90b9c915a3b86eeef60509a6d2bb85d3507d -- Kalle Valo