MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Date: Wed, 05 Sep 2018 12:53:52 +0530
From: Balaji Pothunoori <bpothuno@codeaurora.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: johannes@sipsolutions.net, ath10k@lists.infradead.org,
        linux-wireless@vger.kernel.org
Subject: Re: [PATCHv2 3/3] ath10k: average ack rssi support for data frames
In-Reply-To: <87r2i87dke.fsf@kamboji.qca.qualcomm.com>
References: <1523890122-23952-1-git-send-email-bpothuno@codeaurora.org>
 <1523890122-23952-4-git-send-email-bpothuno@codeaurora.org>
 <87r2i87dke.fsf@kamboji.qca.qualcomm.com>
Message-ID: <65b1a2b72d3c2a73902fe7d65754636a@codeaurora.org> (sfid-20180905_092356_433869_79984BF7)
Sender: linux-wireless-owner@vger.kernel.org

On 2018-09-05 10:20, Kalle Valo wrote:
> Balaji Pothunoori <bpothuno@codeaurora.org> writes:
> 
>> Average ack rssi value is weighted average of ack rssi for
>> no of msdu's has been sent.
>> This feature is enabled by the host driver if firmware is capable.
>> After receiving event from host, firmware allocates the necessary
>> memory to store the ack_rssi for data packets during the init time.
>> 
>> After each successful transmission, If tx completion status is OK
>> and 24th bit is set in HTT message header then host will fetch the
>> ack_rssi else host can ignore the ack_rssi field.
>> 
>> Signed-off-by: Balaji Pothunoori <bpothuno@codeaurora.org>
> 
> There were two new warnings:
> 
> drivers/net/wireless/ath/ath10k/htt_rx.c:1928: line over 90 characters
> drivers/net/wireless/ath/ath10k/mac.c:8511: Alignment should match
> open parenthesis

In v3 i have addressed Alignment warning.

> 
> I fixed those in the pending branch. The first one I solved by adding a
> temporary variable 'msdus'. Please review:

Thanks kalle for optimizing the code , I am fine with the changes.

> 
> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=e4ac90b9c915a3b86eeef60509a6d2bb85d3507d