Date: Mon, 10 Sep 2018 16:08:36 +0530
From: Ajay Singh <ajay.kathat@microchip.com>
To: gregkh <gregkh@linuxfoundation.org>
CC: Arnd Bergmann <arnd@arndb.de>,
        driverdevel <devel@driverdev.osuosl.org>,
        linux-wireless <linux-wireless@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        <ganesh.krishna@microchip.com>, <aditya.shankar@microchip.com>
Subject: Re: [PATCH] staging: wilc1000: revert "fix TODO to compile spi and
 sdio components in single module"
Message-ID: <20180910160836.24efb0b9@ajaysk-VirtualBox> (sfid-20180911_084603_335930_EF65B9F1)
In-Reply-To: <20180814084335.GB7208@kroah.com>
References: <20180813212108.2442868-1-arnd@arndb.de>
        <20180814105237.64b01528@ajaysk-VirtualBox>
        <CAK8P3a3bk7urG9zO=F1NtH8hTnGQQ_Hk0qq=o8fmeYY_nEyy5w@mail.gmail.com>
        <20180814084335.GB7208@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Sender: linux-wireless-owner@vger.kernel.org

Hi Greg,

On Tue, 14 Aug 2018 10:43:35 +0200
gregkh <gregkh@linuxfoundation.org> wrote:

> On Tue, Aug 14, 2018 at 10:34:27AM +0200, Arnd Bergmann wrote:
> > On Tue, Aug 14, 2018 at 7:22 AM Ajay Singh
> > <ajay.kathat@microchip.com> wrote:
> > >
> > > Hi Arnd,
> > >
> > > On Mon, 13 Aug 2018 23:20:33 +0200
> > > Arnd Bergmann <arnd@arndb.de> wrote:
> > >
> > > > The TODO item named "make spi and sdio components coexist in one
> > > > build" was apparently addressed a long time ago, but never
> > > > removed from the TODO file. However, the new patch that tries
> > > > to address it actually makes it worse again by duplicating the
> > > > common parts of the driver into two separate modules rather
> > > > than sharing them. This also introduces a build regression when
> > > > one of the two is built-in while the other is a loadable module:
> > >
> > > Thanks for sharing your inputs and submitting patch.
> > > I have also submitted a patch to address the compilation error[1].
> > > We can ignore my patch and proceed with your changes.
> > >
> > > [1].https://patchwork.kernel.org/patch/10563873/
> > 
> > That patch seems useful regardless, as it removes dead code,
> > but I'd still prefer to revert staging-linusthe 9abc44ba4e2f ("staging: wilc1000:
> > fix TODO to compile spi and sdio components in single module")
> > commit for the other reasons I explained.
> 
> I agree, I'll queue it up soon, I have other patches to get to Linus
> first.
> 

This patch is applied only to 'staging-linus' in commit f45b893 and
it's not applied to 'staging-testing/next' tree. 
Please apply this patch to 'staging-next' tree also. Because I have one
patch to submit on top of these changes to delete the 'wilc_debug.c'
unused file.


Regards,
Ajay