DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4C1A521480
Date:   Tue, 25 Sep 2018 11:07:47 +0200
From:   Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To:     Felix Fietkau <nbd@nbd.name>
Cc:     Stanislaw Gruszka <sgruszka@redhat.com>,
        linux-wireless@vger.kernel.org, Sid Hayn <sidhayn@gmail.com>
Subject: Re: [PATCH] mt76x0: add quirk to disable 2.4GHz band for Archer T1U
Message-ID: <20180925090746.GC3872@localhost.localdomain>
References: <1537858188-7815-1-git-send-email-sgruszka@redhat.com>
 <20180925075445.GA3872@localhost.localdomain>
 <f3c1e576-4756-7a3e-4bfe-3abaf3e1107d@nbd.name>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f3c1e576-4756-7a3e-4bfe-3abaf3e1107d@nbd.name>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Sep 25, Felix Fietkau wrote:
> On 2018-09-25 09:54, Lorenzo Bianconi wrote:
> >>  
> >> diff --git a/drivers/net/wireless/mediatek/mt76/mt76x0/usb.c b/drivers/net/wireless/mediatek/mt76/mt76x0/usb.c
> >> index 76d607f73758..b7a1069ecd0e 100644
> >> --- a/drivers/net/wireless/mediatek/mt76/mt76x0/usb.c
> >> +++ b/drivers/net/wireless/mediatek/mt76/mt76x0/usb.c
> >> @@ -45,7 +45,8 @@
> >>  	{ USB_DEVICE(0x20f4, 0x806b) },	/* TRENDnet TEW-806UBH  */
> >>  	{ USB_DEVICE(0x7392, 0xc711) }, /* Devolo Wifi ac Stick */
> >>  	{ USB_DEVICE(0x0df6, 0x0079) }, /* Sitecom Europe B.V. ac  Stick */
> >> -	{ USB_DEVICE(0x2357, 0x0105) }, /* TP-LINK Archer T1U */
> >> +	{ USB_DEVICE(0x2357, 0x0105),
> >> +	  .driver_info = 1,	     }, /* TP-LINK Archer T1U */
> > 
> > Hi Stanislaw,
> > 
> > what about using 'ieee80211-freq-limit' OF property to limit available wireless
> > band? In this way we can take into account even the opposite case (no 5GHz).
> That doesn't make sense for USB devices, which can be plugged into any
> machine.

Ack, right.
What about a more general solution like adding an enum { NO_5GHz = 1, NO_2GHz }?
Does it worth to implement it now?

Regards,
Lorenzo

> 
> - Felix