DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6091E2086E
Message-ID: <1537954007.28767.10.camel@sipsolutions.net>
Subject: Re: [PATCH] New functionality for aborting ongoing CAC.
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Enrique Giraldo <hgiraldos@gmail.com>,
        linux-wireless@vger.kernel.org
Cc:     Enrique Giraldo <enrique.giraldo@galgus.net>
Date:   Wed, 26 Sep 2018 11:26:47 +0200
In-Reply-To: <20180925081933.28553-1-enrique.giraldo@galgus.net> (sfid-20180925_103015_233939_9CC2DC4E)
References: <20180925081933.28553-1-enrique.giraldo@galgus.net>
         (sfid-20180925_103015_233939_9CC2DC4E)
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Tue, 2018-09-25 at 10:19 +0200, Enrique Giraldo wrote:
> Add NL80211_CMD_ABORT_CAC to the nl80211 interface.

As Arend pointed out, this really needs a much better commit message.

Please also adjust the subject to have a proper prefix etc. See
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
for some help with that.

> @@ -3227,6 +3228,7 @@ struct cfg80211_ops {
>  	int	(*scan)(struct wiphy *wiphy,
>  			struct cfg80211_scan_request *request);
>  	void	(*abort_scan)(struct wiphy *wiphy, struct wireless_dev *wdev);
> +	void	(*abort_cac)(struct wiphy *wiphy, struct wireless_dev *wdev);

This is fine, you can add in the middle of the struct.

> 
> @@ -1220,6 +1223,7 @@ enum nl80211_commands {
>  	NL80211_CMD_WIPHY_REG_CHANGE,
>  
>  	NL80211_CMD_ABORT_SCAN,
> +	NL80211_CMD_ABORT_CAC,
>  
>  	NL80211_CMD_START_NAN,

This is *not* OK, as the comments here indicate, we must never add
anything in the middle of this enum, doing so breaks userspace ABI.

johannes