Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61934C43382 for ; Thu, 27 Sep 2018 04:35:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 17B8921566 for ; Thu, 27 Sep 2018 04:35:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="VTUWMx6i"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="VTUWMx6i" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 17B8921566 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726687AbeI0KvK (ORCPT ); Thu, 27 Sep 2018 06:51:10 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:34244 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726599AbeI0KvK (ORCPT ); Thu, 27 Sep 2018 06:51:10 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id C43A360B0D; Thu, 27 Sep 2018 04:34:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1538022894; bh=xiC4OX4dGrVLb92ktNjWDCjHQHUCJXhAHQqPjbMM8pE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=VTUWMx6iFev9xcj4pM3+9ZsO2P/tVcut04hWo+c0LiHP3ZaYDv1UxhdtnsqlwI3Hg LpIOFx4TJKEYiaLsKOZygGuKgHZDOVjW/jUUhN7PvfqNgZvQYqr5Hx/NNJCjQilkDa Nmk8OTxTzd7HHEiOQRBIL0yI4yfE8AW3YGFNJh2Y= Received: from potku.adurom.net (88-114-240-52.elisa-laajakaista.fi [88.114.240.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 32098607F4; Thu, 27 Sep 2018 04:34:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1538022894; bh=xiC4OX4dGrVLb92ktNjWDCjHQHUCJXhAHQqPjbMM8pE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=VTUWMx6iFev9xcj4pM3+9ZsO2P/tVcut04hWo+c0LiHP3ZaYDv1UxhdtnsqlwI3Hg LpIOFx4TJKEYiaLsKOZygGuKgHZDOVjW/jUUhN7PvfqNgZvQYqr5Hx/NNJCjQilkDa Nmk8OTxTzd7HHEiOQRBIL0yI4yfE8AW3YGFNJh2Y= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 32098607F4 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Cody Schuffelen Cc: Johannes Berg , "David S . Miller" , linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH net-next v2] wireless-drivers: rtnetlink wifi simulation device References: <20180926194324.71290-1-schuffelen@google.com> Date: Thu, 27 Sep 2018 07:34:50 +0300 In-Reply-To: <20180926194324.71290-1-schuffelen@google.com> (Cody Schuffelen's message of "Wed, 26 Sep 2018 12:43:24 -0700") Message-ID: <871s9fr21h.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Cody Schuffelen writes: > This device takes over an existing network device and produces a > new one that appears like a wireless connection, returning enough canned > responses to nl80211 to satisfy a standard network manager. If > necessary, it can also be set up one step removed from an existing > network device, such as through a vlan/80211Q or macvlan connection to > not disrupt the existing network interface. > > To use it to wrap a bare ethernet connection: > > ip link set eth0 down > ip link set eth0 name buried_eth0 > ip link set buried_eth0 up > ip link add link buried_eth0 name wlan0 type virt_wifi > > eth0 is renamed to buried_eth0 to avoid a network manager trying to > manage it, as the original network link will become unusuable and only > the wireless wrapper will be functional. This can also be combined with > vlan or macvlan links on top of eth0 to share the network between > distinct links, but that requires support outside the machine for > accepting vlan-tagged packets or packets from multiple MAC addresses. > > This is being used for Google's Remote Android Virtual Device project, > which runs Android devices in virtual machines. The standard network > interfaces provided inside the virtual machines are all ethernet. > However, Android is not interested in ethernet devices and would rather > connect to a wireless interface. This patch allows the virtual machine > guest to treat one of its network connections as wireless rather than > ethernet, satisfying Android's network connection requirements. > > We believe this is a generally useful driver for simulating wireless > network connections in other environments where a wireless connection is > desired by some userspace process but is not available. Future work can > also include exporting the wireless control plane to userspace, so the > device can configure the behavior of the simulated wireless network > itself. > > This is distinct from other testing efforts such as mac80211_hwsim by > being a cfg80211 device instead of mac80211 device, allowing straight > pass-through on the data plane instead of forcing packaging of ethernet > data into mac80211 frames. > > Signed-off-by: A. Cody Schuffelen > Acked-by: Alistair Strachan > Acked-by: Greg Hartman > Signed-off-by: Cody Schuffelen [...] > --- a/drivers/net/wireless/Kconfig > +++ b/drivers/net/wireless/Kconfig > @@ -114,4 +114,11 @@ config USB_NET_RNDIS_WLAN > > If you choose to build a module, it'll be called rndis_wlan. > > +config VIRT_WIFI > + tristate "Wifi wrapper for ethernet drivers" > + default n Isn't 'n' the default so you don't need to explicitly set that? -- Kalle Valo