DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA81321571
Subject: Re: Problems and suggestions to the kernel module r8723bs
To:     Simon Beginn <simonmicro@simonmicro.de>,
        Bastien Nocera <hadess@hadess.net>,
        Hans de Goede <hdegoede@redhat.com>
Cc:     linux-wireless <linux-wireless@vger.kernel.org>
References: <83c86a2a-0d2a-8119-2831-e9cfab7a43d7@simonmicro.de>
 <f0b67da4-747a-08e3-9744-fce2c74aaddc@lwfinger.net>
 <6e27de67-739f-ee17-eb5f-efb079d1f37f@simonmicro.de>
 <7a47d05c-2f3b-e4d5-ccf1-5c2106d3c93d@lwfinger.net>
 <3a0468ee-e391-3b03-bfc5-36df484bce9d@simonmicro.de>
From:   Larry Finger <Larry.Finger@lwfinger.net>
Message-ID: <9a7105c0-fd23-c7ff-3e28-62533c24cdb9@lwfinger.net>
Date:   Thu, 27 Sep 2018 10:21:01 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.0
MIME-Version: 1.0
In-Reply-To: <3a0468ee-e391-3b03-bfc5-36df484bce9d@simonmicro.de>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 9/27/18 3:33 AM, Simon Beginn wrote:
>> Use the following command to get the baseline values: 
> Done - aand nothing changes (The access point has a strength of -60dB on my 
> desk). Well maybe the manufacturer has two antennas builtin. Yay - sorry for that.

That value means that the signal strength is way too low. One other possibility 
is that the chip has retained the setting and is not obeying the antenna number 
command. To check that, create a file (as root) named 
/etc/modprobe.d/50-r8723bs.conf, and add a single line containing "options 
r8723bs rtw_ant_num=2" (without the quotation marks). After that file is ready, 
then do a cold boot so that the chip has been power cycled. Finally, redo the 
signal test. Note: If your patch is applied, the above will not work!

> 
>> In dmesg
> Yep, too late. I've already installed the necessary firmware-files. But I didn't 
> wrote it, because the WiFi test wasn't performed until yet.
> 
> 
>> o the work to get the driver into the condition necessary for it to be in the 
>> regular tree. 
> Did my patch made it?

Your patch was not in the correct format to be accepted. Even if it had been 
correctly done, I would have NACKed it. Given the location of the driver, the 
name is what it should be. Once you, or someone else, has done the many hours to 
put that Realtek crap into proper kernel form, then it could be placed in the 
normal wireless tree and given the name rtl8723bs.

Larry