DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 10C7621748
Date:   Fri, 28 Sep 2018 09:51:55 +0200
In-Reply-To: <863bc54fbf04441d38dd53f523300a7e@codeaurora.org>
References: <153711966150.9231.13481453399723518107.stgit@alrua-x1> <153711973134.9231.18038849900399644494.stgit@alrua-x1.karlstad.toke.dk> <826b6251746ee4d280d532f4ecdc5aa3@codeaurora.org> <87pnx0haud.fsf@toke.dk> <8f7145bf5abe50194bced025a5e739b9@codeaurora.org> <863bc54fbf04441d38dd53f523300a7e@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PATCH RFC v4 3/4] mac80211: Add airtime accounting and scheduling to TXQs
To:     Rajkumar Manoharan <rmanohar@codeaurora.org>
CC:     linux-wireless@vger.kernel.org,
        make-wifi-fast@lists.bufferbloat.net, Felix Fietkau <nbd@nbd.name>,
        Kan Yan <kyan@google.com>, linux-wireless-owner@vger.kernel.org
From:   =?ISO-8859-1?Q?Toke_H=F8iland-J=F8rgensen?= <toke@toke.dk>
Message-ID: <93015743-5D16-4D79-948F-E2F46CF2450A@toke.dk>
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk


On 28 September 2018 07:29:03 CEST, Rajkumar Manoharan <rmanohar@codeauror=
a=2Eorg> wrote:
>On 2018-09-26 17:09, Rajkumar Manoharan wrote:
>> On 2018-09-26 02:22, Toke H=C3=B8iland-J=C3=B8rgensen wrote:
>>> Rajkumar Manoharan <rmanohar@codeaurora=2Eorg> writes:
>
>> :( Yeah=2E=2E=2E I got confused with attached soft lockup in ARM platfo=
rm=2E
>>=20
>Toke,
>
>Cause for the soft lockup exposed in multi client scenario is due to
>mixed order of fq_lock and active_txqs_lock=2E In wake_tx_queue or=20
>push_pending
>case, driver acquires active_txq_lock first by schedule_start and=20
>followed by
>fq_lock in tx_dequeue=2E The same order should be maintained in sta=20
>cleanup=2E
>Below change fixed the issue=2E

Ah, great find! I'll fold this into the next version, thanks!

-Toke