DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9783C206B6
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
Date:   Fri, 28 Sep 2018 15:47:07 -0700
From:   Rajkumar Manoharan <rmanohar@codeaurora.org>
To:     Ben Greear <greearb@candelatech.com>
Cc:     =?UTF-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>,
        ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
        Kan Yan <kyan@google.com>, linux-wireless-owner@vger.kernel.org
Subject: Re: [RFC 2/2] ath10k: reporting estimated tx airtime for fairness
In-Reply-To: <25469b4a-219d-f941-15ad-a1c95308dd69@candelatech.com>
References: <1538008874-11692-1-git-send-email-rmanohar@codeaurora.org>
 <1538008874-11692-2-git-send-email-rmanohar@codeaurora.org>
 <87lg7lfxtw.fsf@toke.dk> <34bac7851e6c9d3194cef87bd952c388@codeaurora.org>
 <25469b4a-219d-f941-15ad-a1c95308dd69@candelatech.com>
Message-ID: <df1c4f9bde7682646c901305d1c0ab5d@codeaurora.org>
User-Agent: Roundcube Webmail/1.2.5
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 2018-09-28 12:57, Ben Greear wrote:
> On 09/28/2018 12:47 PM, Rajkumar Manoharan wrote:
>> On 2018-09-28 08:25, Toke Høiland-Jørgensen wrote:
>> 
>>> So this just uses the calculated airtime based on rate and size? 
>>> Wasn't
>>> there supposed to be an airtime usage value reported by the firmware? 
>>> :)
>>> 
>> Firmware interface changes are in progress. Airtime for sta/tid will 
>> be reported via
>> htt tx-compl and rx ind messages. Meantime I thought it would be 
>> useful to use Kan's changes
>> for ATF validation in ath10k using existing firmware. :)
> 
> Maybe you can get the firmware guys to report the tx rate in the 
> tx-completion
> (like I have been doing for years in my ath10k-ct firmware)?  Then let 
> the host
> do the air-time calculating?
> 
> I'll give them firmware patches if the want :)
> 
Ben,

As you know, it needs cleanup in firmware to free up space for new 
interface
changes. Most of time we try to leverage rsvd/unused slots. I am aware 
of that
you did a lot of clean up in CT firmware which is quite hard in official
firmware as it also has to support prop. releases. Kalle can answer much 
better.

-Rajkumar