DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 85C4A2073F
Date:   Sat, 29 Sep 2018 02:13:21 +0200
From:   Peter =?UTF-8?B?R3Jvw59l?= <pegro@friiks.de>
To:     linux-wireless@vger.kernel.org
Subject: Handling user regdom hints while having intersected world regdom
Message-ID: <20180929021321.1e1b6c3e@fem-net.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 boundary="Sig_/SoubWZjzh_mzOPe3uPzkooF"; protocol="application/pgp-signature"
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

--Sig_/SoubWZjzh_mzOPe3uPzkooF
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi.

When a setup has multiple wifi cards anounncing different regdoms, the
regularitory subsystem stores an intersected world regdom using aplha2 "98".

I wonder what the correct result should be, when I call "iw reg set 00" or =
with
any other country code?

Because in my system with multiple cards nothing happened.

I added a lot of debug messages and I found the request is rejected with
REG_REQ_IGNORE in __reg_process_hint_user (in net/wireless/reg.c:2371).

In this check, last_request is considered (the request before my user reque=
st),
which in my case was the driver request for the second card leading to the
intersected regdom. But since "98" doesn't match the regdom provided by the
driver, the check returns true and the request gets rejected.

The comment above the check mentions not yet processed requests, but I doubt
that checking the current regdom against the last_request regdom helps in my
case. But from reading the code I got there is a "processed" flag for each
requst.

So maybe a patch like below is enough? Or are there more things to consider?
Or maybe I'm wrong and the current behavior is intended?!

Regards
Peter

diff --git a/net/wireless/reg.c b/net/wireless/reg.c
index 4fc66a117b7d..ed4543c7b255 100644
--- a/net/wireless/reg.c
+++ b/net/wireless/reg.c
@@ -2428,15 +2428,15 @@ __reg_process_hint_user(struct regulatory_request
*user_request) /*
         * Process user requests only after previous user/driver/core
         * requests have been processed
         */
        if ((lr->initiator =3D=3D NL80211_REGDOM_SET_BY_CORE ||
             lr->initiator =3D=3D NL80211_REGDOM_SET_BY_DRIVER ||
             lr->initiator =3D=3D NL80211_REGDOM_SET_BY_USER) &&
-           regdom_changes(lr->alpha2))
+           !lr->processed)
                return REG_REQ_IGNORE;
=20
        if (!regdom_changes(user_request->alpha2))
                return REG_REQ_ALREADY_SET;
=20
        return REG_REQ_OK;
 }

--Sig_/SoubWZjzh_mzOPe3uPzkooF
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEFBMm5T0HjV/btb+Q2Ws8k4f65hoFAluuw6EACgkQ2Ws8k4f6
5hrPfgf/RczY9mUs3AhyvHGNzrXy4o46QpTbkc+OCcIMesQ1V7bgGfGbVmzcIb+/
JAFY4XNY9MEvj3BRLYMGlNvZcoCYcVCm6uwIwHIfk4s+6Zl0NuAiwOFrXzG9TlDD
dbPpiEcVEjiq88HJp90oEtPWLHs5ofuhcFTWXNMc9BkAC7RGncrTr0lvelJZDhCn
mBDMAtM9yOJ0R7MGNJMIItN8UMjW3oSiZpcdku18es42/qkCs+tLBOpFs8a49Gwz
JYYMBKc7m/goJuZEJelQUwanZ2XZEtLzYLZBLMT24NRPhrTbvVyJLqzdiKHna367
UMpKZ+QOmwMeG42gpzOjm291zOctTw==
=8Anj
-----END PGP SIGNATURE-----

--Sig_/SoubWZjzh_mzOPe3uPzkooF--