DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A15B32064D
MIME-Version: 1.0
In-Reply-To: <20180919130456.GA26735@redhat.com>
References: <20180919110540.GC22689@redhat.com> <1537359450-8843-1-git-send-email-pozega.tomislav@gmail.com>
 <20180919124717.GA26590@redhat.com> <20180919130456.GA26735@redhat.com>
From:   Tom Psyborg <pozega.tomislav@gmail.com>
Date:   Sat, 29 Sep 2018 11:26:01 +0200
Message-ID: <CAKR_QVLjwwiamDtL-9ss76p5K=aju1KFYK4iJr=OTGhVsWKuUg@mail.gmail.com>
Subject: Re: [PATCH 1/5] rt2x00: set registers based on current band
To:     Stanislaw Gruszka <sgruszka@redhat.com>
Cc:     linux-wireless@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 19/09/2018, Stanislaw Gruszka <sgruszka@redhat.com> wrote:
> On Wed, Sep 19, 2018 at 02:47:18PM +0200, Stanislaw Gruszka wrote:
>> > Can you show us how will the problem trigger on dual band devices?
>>
>> When you switch from some 2.4GHz channel to 5GHz channel (or vice versa)
>> ->curr_band will point to old band not the new one. To fix that you
>> have to move curr_band assignemt before ->config() in
>> rt2x00lib_config() i.e:
>>
>> rt2x00dev->curr_band = conf->chandef.chan->band;
>> rt2x00dev->ops->lib->config(rt2x00dev, &libconf, ieee80211_flags);
>>
>> However I do not see the point of replacyng rf->channel check
>> to ->curr_band check. What you can do is oposite thing, replace
>> wrong usage of ->curr_band in very few places in rt2800_config()
>> subroutines to rf->channel check.
>
> Actually ->curr_band is used in rt2800_config_ant() subroutines
> not in rt2800_config() subroutines so things looks ok.
>
> Stanislaw
>

Things should be ok, still if you have some of these cards, it'd be
better to verify that.
At least my MS150N usb card would panic when I did the very same
change in rf53xx channel config, probably because of the way the
btcoex idx value has been set.
Luckily I figured that chipset is single-band only and the patch3 was
enough to handle that:
https://www.spinics.net/lists/linux-wireless/msg177430.html